h3n3/kiauh
1
0
Fork 0
Code Issues 46 Pull Requests 10 Packages Projects Releases Wiki Activity

feat: flash DFU device in HID mode #337

Merged
CODeRUS merged 2 commits from patch-1 into master 2023-06-04 21:23:32 +02:00
Conversation 4 Commits 2 Files Changed 1 +48 -35
CODeRUS commented 2023-05-01 12:55:54 +02:00 (Migrated from github.com)
Copy Link
No description provided.
dw-0 (Migrated from github.com) requested changes 2023-06-04 20:04:23 +02:00
scripts/flash_klipper.sh
@@ -88,3 +92,4 @@
break;;
B|b)
advanced_menu
break;;
dw-0 (Migrated from github.com) commented 2023-06-04 20:04:15 +02:00
Copy Link

I think you accidentially missed adding the corresponding UI changes for that selection? (see https://github.com/th33xitus/kiauh/pull/337/files#diff-b89981fc56eaa7eec8db59c1d83d01c49e63add68777fd0da885d2c946b525c9R72) I think there should be a new selection made visible, otherwise users wouldn't even know that "3" is a possible option.

I think you accidentially missed adding the corresponding UI changes for that selection? (see https://github.com/th33xitus/kiauh/pull/337/files#diff-b89981fc56eaa7eec8db59c1d83d01c49e63add68777fd0da885d2c946b525c9R72) I think there should be a new selection made visible, otherwise users wouldn't even know that "3" is a possible option.
CODeRUS (Migrated from github.com) reviewed 2023-06-04 21:15:26 +02:00
scripts/flash_klipper.sh
@@ -88,3 +92,4 @@
break;;
B|b)
advanced_menu
break;;
CODeRUS (Migrated from github.com) commented 2023-06-04 21:15:26 +02:00
Copy Link

oh yes sorry missed to stage line. my bad, fixed now!

oh yes sorry missed to stage line. my bad, fixed now!
dw-0 (Migrated from github.com) approved these changes 2023-06-04 21:23:15 +02:00
dw-0 commented 2023-06-04 21:23:42 +02:00 (Migrated from github.com)
Copy Link

Thank you!

Thank you!
❤️ 2
Sign in to join this conversation.
Reviewers
No Reviewers
CODeRUS
dw-0
Labels
Clear labels
🐛 bug
Something isn't working
 can't reproduce
➕ community extension
crowsnest
duplicate
This issue or pull request already exists
 ✨ feature request
New feature or request
 fluidd
Something that is fluidd related
 improvement
improvement of existing features/code
 invalid
klipper
Something that is klipper related
 klipperscreen
Something that is klipperscreen related
 mainsail
Something that is mainsail related
 mobileraker
moonraker
Something that is moonraker related
 not kiauh
not planned
octoeverywhere
Something that is OctoEverywhere related
 ❓ question
Further information is requested
 💤 stale
todo
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/kiauh#337
Delete Branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?