h3n3/kiauh
1
0
Fork 0
Code Issues 46 Pull Requests 10 Packages Projects Releases Wiki Activity

bug: missing moonraker restart after patching update manager #225

New Issue
Closed
opened 2022-07-21 13:42:26 +02:00 by dw-0 · 0 comments
dw-0 commented 2022-07-21 13:42:26 +02:00 (Migrated from github.com)
Copy Link

It is required to run a moonraker restart after/inside those functions.

ae011963da/scripts/mainsail.sh (L571)

ae011963da/scripts/fluidd.sh (L397)

ae011963da/scripts/klipperscreen.sh (L204)

ae011963da/scripts/moonraker-telegram-bot.sh (L460)

Otherwise the modified moonraker.conf will not be applied immediately and users have to restart moonraker themself before they are able to see the components listed in clients update manager.

It is required to run a moonraker restart after/inside those functions. https://github.com/th33xitus/kiauh/blob/ae011963da3fb93ee94d8f8e32ec0c5387b05b1c/scripts/mainsail.sh#L571 https://github.com/th33xitus/kiauh/blob/ae011963da3fb93ee94d8f8e32ec0c5387b05b1c/scripts/fluidd.sh#L397 https://github.com/th33xitus/kiauh/blob/ae011963da3fb93ee94d8f8e32ec0c5387b05b1c/scripts/klipperscreen.sh#L204 https://github.com/th33xitus/kiauh/blob/ae011963da3fb93ee94d8f8e32ec0c5387b05b1c/scripts/moonraker-telegram-bot.sh#L460 Otherwise the modified moonraker.conf will not be applied immediately and users have to restart moonraker themself before they are able to see the components listed in clients update manager.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🐛 bug
Something isn't working
 can't reproduce
➕ community extension
crowsnest
duplicate
This issue or pull request already exists
 ✨ feature request
New feature or request
 fluidd
Something that is fluidd related
 improvement
improvement of existing features/code
 invalid
klipper
Something that is klipper related
 klipperscreen
Something that is klipperscreen related
 mainsail
Something that is mainsail related
 mobileraker
moonraker
Something that is moonraker related
 not kiauh
not planned
octoeverywhere
Something that is OctoEverywhere related
 ❓ question
Further information is requested
 💤 stale
todo
wontfix
This will not be worked on
No Label 🐛 bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/kiauh#225
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?