h3n3/kiauh
1
0
Fork 0
Code Issues 46 Pull Requests 10 Packages Projects Releases Wiki Activity

Entering 'No' in continue when flashing still continues to flash the device #155

New Issue
Closed
opened 2021-12-19 07:05:42 +01:00 by alexyao2015 · 1 comment
alexyao2015 commented 2021-12-19 07:05:42 +01:00 (Migrated from github.com)
Copy Link

What happened

/=======================================================\
|     ~~~~~~~~~~~~~~~~~ [ KIAUH ] ~~~~~~~~~~~~~~~~~     |
|        Klipper Installation And Update Helper         |
|     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~     |
\=======================================================/

###### Please wait...

###### Initializing firmware build ...

###### Checking for the following dependencies:
● build-essential
● dpkg-dev
● make
>>>>>> Dependencies already met! Continue...
Using default symbol values (no '/home/klipper/klipper/.config')
Configuration saved to '/home/klipper/klipper/.config'
  Creating symbolic link out/board
  Creating symbolic link out/board
Loaded configuration '/home/klipper/klipper/.config'
No changes to save (for '/home/klipper/klipper/.config')

###### Building firmware ...
  Building out/autoconf.h
  Compiling out/src/sched.o
  Compiling out/src/command.o
  Compiling out/src/basecmd.o
  Compiling out/src/debugcmds.o
  Compiling out/src/initial_pins.o
  Compiling out/src/gpiocmds.o
  Compiling out/src/stepper.o
  Compiling out/src/endstop.o
  Compiling out/src/trsync.o
  Compiling out/src/adccmds.o
  Compiling out/src/spicmds.o
  Compiling out/src/thermocouple.o
  Compiling out/src/i2ccmds.o
  Compiling out/src/pwmcmds.o
  Compiling out/src/spi_software.o
  Compiling out/src/sensor_adxl345.o
  Compiling out/src/lcd_st7920.o
  Compiling out/src/lcd_hd44780.o
  Compiling out/src/buttons.o
  Compiling out/src/tmcuart.o
  Compiling out/src/neopixel.o
  Compiling out/src/pulse_counter.o
  Compiling out/src/avr/main.o
  Compiling out/src/avr/timer.o
  Compiling out/src/avr/gpio.o
  Compiling out/src/avr/adc.o
  Compiling out/src/avr/spi.o
  Compiling out/src/avr/i2c.o
  Compiling out/src/avr/hard_pwm.o
  Compiling out/src/avr/watchdog.o
  Compiling out/src/avr/serial.o
  Compiling out/src/generic/serial_irq.o
  Building out/compile_time_request.o
Version: v0.10.0-184-gdd714fc7
  Linking out/klipper.elf
  Creating hex file out/klipper.elf.hex
>>>>>> Firmware built!
/=======================================================\
|        ~~~~~~~~~~~~ [ Flash MCU ] ~~~~~~~~~~~~        |
|-------------------------------------------------------|
| Please select the flashing method to flash your MCU.  |
| Make sure to only select a method your MCU supports.  |
| Not all MCUs support both methods!                    |
|-------------------------------------------------------|
|                                                       |
| 1) Regular flashing method                            |
| 2) Updating via SD-Card Update                        |
|                                                       |
|-------------------------------------------------------|
|         B) « Back         |        H) Help [?]        |
\=======================================================/
###### Please select: 1
###### > Regular flashing method

/=======================================================\
| Make sure to have the controller board connected now! |
|                                                       |
| How is the controller board connected to the host?    |
| 1) USB                                                |
| 2) UART                                               |
\=======================================================/
###### Connection method: 1

###### Identifying MCU ...
 ● (USB) MCU #1: /dev/serial/by-id/usb-1a86_USB_Serial-if00-port0

/=======================================================\
|                   !!! ATTENTION !!!                   |
|-------------------------------------------------------|
| Make sure, to select the correct MCU!                 |
| ONLY flash a firmware created for the respective MCU! |
\=======================================================/
###### List of available MCU:
 1) /dev/serial/by-id/usb-1a86_USB_Serial-if00-port0

###### Select MCU to flash: 1

###### You selected:
 ● MCU #1: /dev/serial/by-id/usb-1a86_USB_Serial-if00-port0

###### Continue? (Y/n): n
###### > No

###### Stopping klipper.service ...
>>>>>> klipper.service stopped!
  Flashing out/klipper.elf.hex to /dev/serial/by-id/usb-1a86_USB_Serial-if00-por                                                                                                                                                             t0 via avrdude

avrdude: AVR device initialized and ready to accept instructions

Reading | ################################################## | 100% 0.01s

avrdude: Device signature = 0x1e9801 (probably m2560)
avrdude: reading input file "out/klipper.elf.hex"
avrdude: writing flash (26468 bytes):

Writing | ################################################## | 100% 4.15s

avrdude: 26468 bytes of flash written
avrdude: verifying flash memory against out/klipper.elf.hex:
avrdude: load data flash data from input file out/klipper.elf.hex:
avrdude: input file out/klipper.elf.hex contains 26468 bytes
avrdude: reading on-chip flash data:

Reading | ################################################## | 100% 3.20s

avrdude: verifying ...
avrdude: 26468 bytes of flash verified

avrdude: safemode: Fuses OK (E:FD, H:D8, L:FF)

avrdude done.  Thank you.

>>>>>> Flashing successfull!

###### Starting klipper.service ...
>>>>>> klipper.service started!

What did you expect to happen

Continue no should stop the script

How to reproduce

Enter flash and build, proceed to last step before confirmation, enter n. Watch as script continues to flash

Additional information

No response

### What happened ``` /=======================================================\ | ~~~~~~~~~~~~~~~~~ [ KIAUH ] ~~~~~~~~~~~~~~~~~ | | Klipper Installation And Update Helper | | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | \=======================================================/ ###### Please wait... ###### Initializing firmware build ... ###### Checking for the following dependencies: ● build-essential ● dpkg-dev ● make >>>>>> Dependencies already met! Continue... Using default symbol values (no '/home/klipper/klipper/.config') Configuration saved to '/home/klipper/klipper/.config' Creating symbolic link out/board Creating symbolic link out/board Loaded configuration '/home/klipper/klipper/.config' No changes to save (for '/home/klipper/klipper/.config') ###### Building firmware ... Building out/autoconf.h Compiling out/src/sched.o Compiling out/src/command.o Compiling out/src/basecmd.o Compiling out/src/debugcmds.o Compiling out/src/initial_pins.o Compiling out/src/gpiocmds.o Compiling out/src/stepper.o Compiling out/src/endstop.o Compiling out/src/trsync.o Compiling out/src/adccmds.o Compiling out/src/spicmds.o Compiling out/src/thermocouple.o Compiling out/src/i2ccmds.o Compiling out/src/pwmcmds.o Compiling out/src/spi_software.o Compiling out/src/sensor_adxl345.o Compiling out/src/lcd_st7920.o Compiling out/src/lcd_hd44780.o Compiling out/src/buttons.o Compiling out/src/tmcuart.o Compiling out/src/neopixel.o Compiling out/src/pulse_counter.o Compiling out/src/avr/main.o Compiling out/src/avr/timer.o Compiling out/src/avr/gpio.o Compiling out/src/avr/adc.o Compiling out/src/avr/spi.o Compiling out/src/avr/i2c.o Compiling out/src/avr/hard_pwm.o Compiling out/src/avr/watchdog.o Compiling out/src/avr/serial.o Compiling out/src/generic/serial_irq.o Building out/compile_time_request.o Version: v0.10.0-184-gdd714fc7 Linking out/klipper.elf Creating hex file out/klipper.elf.hex >>>>>> Firmware built! /=======================================================\ | ~~~~~~~~~~~~ [ Flash MCU ] ~~~~~~~~~~~~ | |-------------------------------------------------------| | Please select the flashing method to flash your MCU. | | Make sure to only select a method your MCU supports. | | Not all MCUs support both methods! | |-------------------------------------------------------| | | | 1) Regular flashing method | | 2) Updating via SD-Card Update | | | |-------------------------------------------------------| | B) « Back | H) Help [?] | \=======================================================/ ###### Please select: 1 ###### > Regular flashing method /=======================================================\ | Make sure to have the controller board connected now! | | | | How is the controller board connected to the host? | | 1) USB | | 2) UART | \=======================================================/ ###### Connection method: 1 ###### Identifying MCU ... ● (USB) MCU #1: /dev/serial/by-id/usb-1a86_USB_Serial-if00-port0 /=======================================================\ | !!! ATTENTION !!! | |-------------------------------------------------------| | Make sure, to select the correct MCU! | | ONLY flash a firmware created for the respective MCU! | \=======================================================/ ###### List of available MCU: 1) /dev/serial/by-id/usb-1a86_USB_Serial-if00-port0 ###### Select MCU to flash: 1 ###### You selected: ● MCU #1: /dev/serial/by-id/usb-1a86_USB_Serial-if00-port0 ###### Continue? (Y/n): n ###### > No ###### Stopping klipper.service ... >>>>>> klipper.service stopped! Flashing out/klipper.elf.hex to /dev/serial/by-id/usb-1a86_USB_Serial-if00-por t0 via avrdude avrdude: AVR device initialized and ready to accept instructions Reading | ################################################## | 100% 0.01s avrdude: Device signature = 0x1e9801 (probably m2560) avrdude: reading input file "out/klipper.elf.hex" avrdude: writing flash (26468 bytes): Writing | ################################################## | 100% 4.15s avrdude: 26468 bytes of flash written avrdude: verifying flash memory against out/klipper.elf.hex: avrdude: load data flash data from input file out/klipper.elf.hex: avrdude: input file out/klipper.elf.hex contains 26468 bytes avrdude: reading on-chip flash data: Reading | ################################################## | 100% 3.20s avrdude: verifying ... avrdude: 26468 bytes of flash verified avrdude: safemode: Fuses OK (E:FD, H:D8, L:FF) avrdude done. Thank you. >>>>>> Flashing successfull! ###### Starting klipper.service ... >>>>>> klipper.service started! ``` ### What did you expect to happen Continue no should stop the script ### How to reproduce Enter flash and build, proceed to last step before confirmation, enter n. Watch as script continues to flash ### Additional information _No response_
dw-0 commented 2021-12-19 09:23:24 +01:00 (Migrated from github.com)
Copy Link

That indeed seems to be a bug. That should not happen. Thank you for reporting. I will investigate that issue!

That indeed seems to be a bug. That should not happen. Thank you for reporting. I will investigate that issue!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🐛 bug
Something isn't working
 can't reproduce
➕ community extension
crowsnest
duplicate
This issue or pull request already exists
 ✨ feature request
New feature or request
 fluidd
Something that is fluidd related
 improvement
improvement of existing features/code
 invalid
klipper
Something that is klipper related
 klipperscreen
Something that is klipperscreen related
 mainsail
Something that is mainsail related
 mobileraker
moonraker
Something that is moonraker related
 not kiauh
not planned
octoeverywhere
Something that is OctoEverywhere related
 ❓ question
Further information is requested
 💤 stale
todo
wontfix
This will not be worked on
No Label 🐛 bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/kiauh#155
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?