support more than 9 instances #129

New Issue

2021-10-22T22:19:20+02:00

stevenvo commented

2021-10-22 22:19:20 +02:00

(Migrated from github.com)

Current installation only support single digit of instance count, is there any specific reason?
f231fa9c69/scripts/install_klipper.sh (L26)

Current installation only support single digit of instance count, is there any specific reason? https://github.com/th33xitus/kiauh/blob/f231fa9c69191f23277b4e3319f6b675bfa0ee42/scripts/install_klipper.sh#L26

dw-0 commented

2021-10-22 22:54:37 +02:00

(Migrated from github.com)

The quantifier is a +, which means one or more occurences of characters of the preceding character group (1 to 9) are allowed. Therefore it is very possible to install more than 9 instances.

The quantifier is a `+`, which means one or more occurences of characters of the preceding character group (1 to 9) are allowed. Therefore it is very possible to install more than 9 instances.

stevenvo commented

2021-10-22 23:13:34 +02:00

(Migrated from github.com)

oh actually my bad, it does support more digits. it just does not support if the number has digit 0 in it. since you only allow 1-9 digit

stevenvo commented

2021-10-22 23:13:50 +02:00

(Migrated from github.com)

so number of instance 10, 20, etc wont work

dw-0 commented

2021-10-22 23:16:23 +02:00

(Migrated from github.com)

Good point, you are right. I put that on my todo to fix.

stevenvo commented

2021-11-07 04:01:26 +01:00

(Migrated from github.com)

appreciate!

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: h3n3/kiauh#129