From 2993d5ed3347982089913e4b5007b9ca1e36831a Mon Sep 17 00:00:00 2001
From: th33xitus <th33xitus@googlemail.com>
Date: Sat, 19 Mar 2022 01:13:26 +0100
Subject: [PATCH] refactor: make `dependency_check()` take an array as first
 argument

Signed-off-by: Dominik Willner th33xitus@gmail.com
---
 scripts/functions.sh | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/scripts/functions.sh b/scripts/functions.sh
index 37180c8..47f264b 100755
--- a/scripts/functions.sh
+++ b/scripts/functions.sh
@@ -233,24 +233,25 @@ restart_nginx(){
 }
 
 dependency_check(){
+  local dep="${1}" # dep: array
   status_msg "Checking for the following dependencies:"
   #check if package is installed, if not write name into array
-  for pkg in "${dep[@]}"
+  for pkg in ${dep}
   do
-    echo -e "${cyan}● $pkg ${default}"
-    if [[ ! $(dpkg-query -f'${Status}' --show $pkg 2>/dev/null) = *\ installed ]]; then
-      inst+=($pkg)
+    echo -e "${cyan}● ${pkg} ${default}"
+    if [[ ! $(dpkg-query -f'${Status}' --show "${pkg}" 2>/dev/null) = *\ installed ]]; then
+      inst+=("${pkg}")
     fi
   done
   #if array is not empty, install packages from array elements
-  if [ "${#inst[@]}" != "0" ]; then
+  if [ "${#inst[@]}" -ne 0 ]; then
     status_msg "Installing the following dependencies:"
-    for element in ${inst[@]}
+    for element in "${inst[@]}"
     do
-      echo -e "${cyan}● $element ${default}"
+      echo -e "${cyan}● ${element} ${default}"
     done
     echo
-    sudo apt-get update --allow-releaseinfo-change && sudo apt-get install ${inst[@]} -y
+    sudo apt-get update --allow-releaseinfo-change && sudo apt-get install "${inst[@]}" -y
     ok_msg "Dependencies installed!"
     #clearing the array
     unset inst