h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

FEAT: Create basic model embed #588

Merged
franknoirot merged 7 commits from feat-embed into main 2022-01-11 07:30:15 +01:00
Conversation 6 Commits 7 Files Changed 16 +3 -28
2 changed files with 3 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 931e9607bf - Show all commits

3
app/web/src/components/EmbedProject/EmbedProject.tsx
View File

@@ -16,12 +16,11 @@ const EmbedProject = ({ project }: Props) => {
Irev-Dev commented 2022-01-10 20:32:08 +01:00 (Migrated from github.com)
Review
Copy Link

Could we remove the log?

Could we remove the log?
Irev-Dev commented 2022-01-10 20:32:08 +01:00 (Migrated from github.com)
Review
Copy Link

Could we remove the log?

Could we remove the log?
franknoirot commented 2022-01-11 03:07:20 +01:00 (Migrated from github.com)
Review
Copy Link

Complete.

Complete.
franknoirot commented 2022-01-11 03:07:20 +01:00 (Migrated from github.com)
Review
Copy Link

Complete.

Complete.
const { viewerDomRef, handleViewerSizeUpdate } = use3dViewerResize()
useEffect(() => {
console.log({ rect: viewerDomRef.current.getBoundingClientRect(), status: 'uh what?'})
Irev-Dev commented 2022-01-10 20:32:08 +01:00 (Migrated from github.com)
Review
Copy Link

Could we remove the log?

Could we remove the log?
franknoirot commented 2022-01-11 03:07:20 +01:00 (Migrated from github.com)
Review
Copy Link

Complete.

Complete.
handleViewerSizeUpdate()
}, [])
return (
<div className="h-screen flex flex-col" ref={viewerDomRef} >
Irev-Dev commented 2022-01-10 20:32:08 +01:00 (Migrated from github.com)
Review
Copy Link

Could we remove the log?

Could we remove the log?
franknoirot commented 2022-01-11 03:07:20 +01:00 (Migrated from github.com)
Review
Copy Link

Complete.

Complete.
<div className="flex flex-col h-screen" ref={viewerDomRef} >
Irev-Dev commented 2022-01-10 20:32:08 +01:00 (Migrated from github.com)
Review
Copy Link

Could we remove the log?

Could we remove the log?
franknoirot commented 2022-01-11 03:07:20 +01:00 (Migrated from github.com)
Review
Copy Link

Complete.

Complete.
<IdeContext.Provider value={{ state, thunkDispatch, project }}>
<IdeViewer />
</IdeContext.Provider>
Irev-Dev commented 2022-01-10 20:32:08 +01:00 (Migrated from github.com)
Review
Copy Link

Could we remove the log?

Could we remove the log?
Irev-Dev commented 2022-01-10 20:32:08 +01:00 (Migrated from github.com)
Review
Copy Link

Could we remove the log?

Could we remove the log?
franknoirot commented 2022-01-11 03:07:20 +01:00 (Migrated from github.com)
Review
Copy Link

Complete.

Complete.
franknoirot commented 2022-01-11 03:07:20 +01:00 (Migrated from github.com)
Review
Copy Link

Complete.

Complete.

28
app/web/src/components/EmbedProjectCell/EmbedProjectCell.tsx
View File

@@ -1,33 +1,9 @@
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
import useUser from 'src/helpers/hooks/useUser'
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
import { useIdeState } from 'src/helpers/hooks/useIdeState'
import { IdeContext } from 'src/helpers/hooks/useIdeContext'
import EmbedViewer from '../EmbedViewer/EmbedViewer'
import { QUERY as IdeQuery } from 'src/components/IdeProjectCell'
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
export const QUERY = gql`
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
query FIND_PROJECT_BY_USENAME_TITLE(
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
$projectTitle: String!
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
$userName: String!
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
) {
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
project: projectByUserAndTitle(
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
projectTitle: $projectTitle
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
userName: $userName
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
) {
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
id
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
title
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
description
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
code
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
mainImage
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
createdAt
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
cadPackage
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
user {
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
id
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
userName
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
image
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
}
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
}
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
}
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
`
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
export const QUERY = IdeQuery
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
export interface Project {
id: string
title: string
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
Irev-Dev commented 2022-01-10 20:36:32 +01:00 (Migrated from github.com)
Review
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
franknoirot commented 2022-01-11 03:07:30 +01:00 (Migrated from github.com)
Review
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.