h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

Sidebar tray #507

Merged
Irev-Dev merged 12 commits from sidebar-tray into main 2021-09-18 08:22:13 +02:00
Conversation 11 Commits 12 Files Changed 14 +6 -14
2 changed files with 6 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 011baad9d0 - Show all commits

18
app/web/src/components/IdeSideBar/sidebarConfig.tsx
View File

@@ -1,11 +1,11 @@
Irev-Dev commented 2021-09-12 12:03:12 +02:00 (Migrated from github.com)
Review
Copy Link

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this.

I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly

a button anywhere on the page can open the tray

indicates to me this should be handled through app state

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this. I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly > a button anywhere on the page can open the tray indicates to me this should be handled through app state
Irev-Dev commented 2021-09-12 12:03:12 +02:00 (Migrated from github.com)
Review
Copy Link

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this.

I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly

a button anywhere on the page can open the tray

indicates to me this should be handled through app state

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this. I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly > a button anywhere on the page can open the tray indicates to me this should be handled through app state
franknoirot commented 2021-09-12 18:44:08 +02:00 (Migrated from github.com)
Review
Copy Link

Love this thank you I will take a look

Love this thank you I will take a look
franknoirot commented 2021-09-12 18:44:08 +02:00 (Migrated from github.com)
Review
Copy Link

Love this thank you I will take a look

Love this thank you I will take a look
import { ReactFragment, ReactNode, useEffect, useReducer, useState } from 'react'
Irev-Dev commented 2021-09-12 12:03:12 +02:00 (Migrated from github.com)
Review
Copy Link

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this.

I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly

a button anywhere on the page can open the tray

indicates to me this should be handled through app state

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this. I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly > a button anywhere on the page can open the tray indicates to me this should be handled through app state
franknoirot commented 2021-09-12 18:44:08 +02:00 (Migrated from github.com)
Review
Copy Link

Love this thank you I will take a look

Love this thank you I will take a look
import React, { ReactNode } from 'react'
Irev-Dev commented 2021-09-12 12:03:12 +02:00 (Migrated from github.com)
Review
Copy Link

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this.

I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly

a button anywhere on the page can open the tray

indicates to me this should be handled through app state

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this. I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly > a button anywhere on the page can open the tray indicates to me this should be handled through app state
franknoirot commented 2021-09-12 18:44:08 +02:00 (Migrated from github.com)
Review
Copy Link

Love this thank you I will take a look

Love this thank you I will take a look
import { SvgNames } from 'src/components/Svg/Svg'
interface SidebarConfigType {
name: string,
icon: SvgNames,
disabled: boolean,
panel: ReactFragment | null,
Irev-Dev commented 2021-09-12 12:03:12 +02:00 (Migrated from github.com)
Review
Copy Link

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this.

I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly

a button anywhere on the page can open the tray

indicates to me this should be handled through app state

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this. I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly > a button anywhere on the page can open the tray indicates to me this should be handled through app state
franknoirot commented 2021-09-12 18:44:08 +02:00 (Migrated from github.com)
Review
Copy Link

Love this thank you I will take a look

Love this thank you I will take a look
panel: ReactNode | null,
Irev-Dev commented 2021-09-12 12:03:12 +02:00 (Migrated from github.com)
Review
Copy Link

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this.

I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly

a button anywhere on the page can open the tray

indicates to me this should be handled through app state

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this. I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly > a button anywhere on the page can open the tray indicates to me this should be handled through app state
franknoirot commented 2021-09-12 18:44:08 +02:00 (Migrated from github.com)
Review
Copy Link

Love this thank you I will take a look

Love this thank you I will take a look
}
export const sidebarTopConfig : SidebarConfigType[] = [
@@ -67,14 +67,7 @@ export const sidebarBottomConfig : SidebarConfigType[] = [
Irev-Dev commented 2021-09-12 12:03:12 +02:00 (Migrated from github.com)
Review
Copy Link

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this.

I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly

a button anywhere on the page can open the tray

indicates to me this should be handled through app state

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this. I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly > a button anywhere on the page can open the tray indicates to me this should be handled through app state
Irev-Dev commented 2021-09-12 12:03:12 +02:00 (Migrated from github.com)
Review
Copy Link

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this.

I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly

a button anywhere on the page can open the tray

indicates to me this should be handled through app state

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this. I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly > a button anywhere on the page can open the tray indicates to me this should be handled through app state
franknoirot commented 2021-09-12 18:44:08 +02:00 (Migrated from github.com)
Review
Copy Link

Love this thank you I will take a look

Love this thank you I will take a look
franknoirot commented 2021-09-12 18:44:08 +02:00 (Migrated from github.com)
Review
Copy Link

Love this thank you I will take a look

Love this thank you I will take a look
name: 'Settings',
icon: 'gear',
disabled: false,
panel: <article className="">
Irev-Dev commented 2021-09-12 12:03:12 +02:00 (Migrated from github.com)
Review
Copy Link

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this.

I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly

a button anywhere on the page can open the tray

indicates to me this should be handled through app state

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this. I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly > a button anywhere on the page can open the tray indicates to me this should be handled through app state
franknoirot commented 2021-09-12 18:44:08 +02:00 (Migrated from github.com)
Review
Copy Link

Love this thank you I will take a look

Love this thank you I will take a look
{ settingsConfig.map(item => (
Irev-Dev commented 2021-09-12 12:03:12 +02:00 (Migrated from github.com)
Review
Copy Link

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this.

I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly

a button anywhere on the page can open the tray

indicates to me this should be handled through app state

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this. I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly > a button anywhere on the page can open the tray indicates to me this should be handled through app state
franknoirot commented 2021-09-12 18:44:08 +02:00 (Migrated from github.com)
Review
Copy Link

Love this thank you I will take a look

Love this thank you I will take a look
<details key={'settings-tray-'+item.name}>
Irev-Dev commented 2021-09-12 12:03:12 +02:00 (Migrated from github.com)
Review
Copy Link

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this.

I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly

a button anywhere on the page can open the tray

indicates to me this should be handled through app state

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this. I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly > a button anywhere on the page can open the tray indicates to me this should be handled through app state
franknoirot commented 2021-09-12 18:44:08 +02:00 (Migrated from github.com)
Review
Copy Link

Love this thank you I will take a look

Love this thank you I will take a look
<summary className="px-2 py-1 bg-ch-pink-800 bg-opacity-20 my-px">{ item.title }</summary>
Irev-Dev commented 2021-09-12 12:03:12 +02:00 (Migrated from github.com)
Review
Copy Link

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this.

I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly

a button anywhere on the page can open the tray

indicates to me this should be handled through app state

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this. I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly > a button anywhere on the page can open the tray indicates to me this should be handled through app state
franknoirot commented 2021-09-12 18:44:08 +02:00 (Migrated from github.com)
Review
Copy Link

Love this thank you I will take a look

Love this thank you I will take a look
{ item.content }
Irev-Dev commented 2021-09-12 12:03:12 +02:00 (Migrated from github.com)
Review
Copy Link

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this.

I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly

a button anywhere on the page can open the tray

indicates to me this should be handled through app state

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this. I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly > a button anywhere on the page can open the tray indicates to me this should be handled through app state
franknoirot commented 2021-09-12 18:44:08 +02:00 (Migrated from github.com)
Review
Copy Link

Love this thank you I will take a look

Love this thank you I will take a look
</details>
Irev-Dev commented 2021-09-12 12:03:12 +02:00 (Migrated from github.com)
Review
Copy Link

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this.

I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly

a button anywhere on the page can open the tray

indicates to me this should be handled through app state

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this. I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly > a button anywhere on the page can open the tray indicates to me this should be handled through app state
franknoirot commented 2021-09-12 18:44:08 +02:00 (Migrated from github.com)
Review
Copy Link

Love this thank you I will take a look

Love this thank you I will take a look
))}
Irev-Dev commented 2021-09-12 12:03:12 +02:00 (Migrated from github.com)
Review
Copy Link

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this.

I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly

a button anywhere on the page can open the tray

indicates to me this should be handled through app state

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this. I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly > a button anywhere on the page can open the tray indicates to me this should be handled through app state
franknoirot commented 2021-09-12 18:44:08 +02:00 (Migrated from github.com)
Review
Copy Link

Love this thank you I will take a look

Love this thank you I will take a look
</article>,
Irev-Dev commented 2021-09-12 12:03:12 +02:00 (Migrated from github.com)
Review
Copy Link

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this.

I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly

a button anywhere on the page can open the tray

indicates to me this should be handled through app state

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this. I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly > a button anywhere on the page can open the tray indicates to me this should be handled through app state
franknoirot commented 2021-09-12 18:44:08 +02:00 (Migrated from github.com)
Review
Copy Link

Love this thank you I will take a look

Love this thank you I will take a look
panel: <SettingsMenu />,
Irev-Dev commented 2021-09-12 12:03:12 +02:00 (Migrated from github.com)
Review
Copy Link

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this.

I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly

a button anywhere on the page can open the tray

indicates to me this should be handled through app state

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this. I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly > a button anywhere on the page can open the tray indicates to me this should be handled through app state
franknoirot commented 2021-09-12 18:44:08 +02:00 (Migrated from github.com)
Review
Copy Link

Love this thank you I will take a look

Love this thank you I will take a look
},
]
@@ -84,12 +77,11 @@ export const sidebarCombinedConfig = [
Irev-Dev commented 2021-09-12 12:03:12 +02:00 (Migrated from github.com)
Review
Copy Link

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this.

I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly

a button anywhere on the page can open the tray

indicates to me this should be handled through app state

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this. I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly > a button anywhere on the page can open the tray indicates to me this should be handled through app state
Irev-Dev commented 2021-09-12 12:03:12 +02:00 (Migrated from github.com)
Review
Copy Link

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this.

I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly

a button anywhere on the page can open the tray

indicates to me this should be handled through app state

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this. I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly > a button anywhere on the page can open the tray indicates to me this should be handled through app state
franknoirot commented 2021-09-12 18:44:08 +02:00 (Migrated from github.com)
Review
Copy Link

Love this thank you I will take a look

Love this thank you I will take a look
franknoirot commented 2021-09-12 18:44:08 +02:00 (Migrated from github.com)
Review
Copy Link

Love this thank you I will take a look

Love this thank you I will take a look
]
function SettingsMenu() {
console.log('hello?', settingsConfig)
Irev-Dev commented 2021-09-12 12:03:12 +02:00 (Migrated from github.com)
Review
Copy Link

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this.

I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly

a button anywhere on the page can open the tray

indicates to me this should be handled through app state

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this. I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly > a button anywhere on the page can open the tray indicates to me this should be handled through app state
franknoirot commented 2021-09-12 18:44:08 +02:00 (Migrated from github.com)
Review
Copy Link

Love this thank you I will take a look

Love this thank you I will take a look
return (
<article className="px-2 py-4">
Irev-Dev commented 2021-09-12 12:03:12 +02:00 (Migrated from github.com)
Review
Copy Link

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this.

I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly

a button anywhere on the page can open the tray

indicates to me this should be handled through app state

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this. I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly > a button anywhere on the page can open the tray indicates to me this should be handled through app state
franknoirot commented 2021-09-12 18:44:08 +02:00 (Migrated from github.com)
Review
Copy Link

Love this thank you I will take a look

Love this thank you I will take a look
<article className="">
Irev-Dev commented 2021-09-12 12:03:12 +02:00 (Migrated from github.com)
Review
Copy Link

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this.

I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly

a button anywhere on the page can open the tray

indicates to me this should be handled through app state

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this. I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly > a button anywhere on the page can open the tray indicates to me this should be handled through app state
franknoirot commented 2021-09-12 18:44:08 +02:00 (Migrated from github.com)
Review
Copy Link

Love this thank you I will take a look

Love this thank you I will take a look
{ settingsConfig.map(item => (
<details key={'settings-tray-'+item.name}>
<summary>{ item.title }</summary>
Irev-Dev commented 2021-09-12 12:03:12 +02:00 (Migrated from github.com)
Review
Copy Link

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this.

I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly

a button anywhere on the page can open the tray

indicates to me this should be handled through app state

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this. I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly > a button anywhere on the page can open the tray indicates to me this should be handled through app state
franknoirot commented 2021-09-12 18:44:08 +02:00 (Migrated from github.com)
Review
Copy Link

Love this thank you I will take a look

Love this thank you I will take a look
<summary className="px-2 py-2 bg-ch-pink-800 bg-opacity-10 my-px">{ item.title }</summary>
Irev-Dev commented 2021-09-12 12:03:12 +02:00 (Migrated from github.com)
Review
Copy Link

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this.

I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly

a button anywhere on the page can open the tray

indicates to me this should be handled through app state

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this. I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly > a button anywhere on the page can open the tray indicates to me this should be handled through app state
franknoirot commented 2021-09-12 18:44:08 +02:00 (Migrated from github.com)
Review
Copy Link

Love this thank you I will take a look

Love this thank you I will take a look
{ item.content }
</details>
))}
Irev-Dev commented 2021-09-12 12:03:12 +02:00 (Migrated from github.com)
Review
Copy Link

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this.

I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly

a button anywhere on the page can open the tray

indicates to me this should be handled through app state

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this. I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly > a button anywhere on the page can open the tray indicates to me this should be handled through app state
Irev-Dev commented 2021-09-12 12:03:12 +02:00 (Migrated from github.com)
Review
Copy Link

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this.

I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly

a button anywhere on the page can open the tray

indicates to me this should be handled through app state

This open param looks like it wasn't used, so not sure what the plan was with it here, but it smells a little to me, in that this data structure contains with copy/user info, and app state and I think it will be hard to manage like this. I've made a commit with a demo of the tray being controlled by the app data store, which I think is probably the right approach, even thinking about it abstractly > a button anywhere on the page can open the tray indicates to me this should be handled through app state
franknoirot commented 2021-09-12 18:44:08 +02:00 (Migrated from github.com)
Review
Copy Link

Love this thank you I will take a look

Love this thank you I will take a look
franknoirot commented 2021-09-12 18:44:08 +02:00 (Migrated from github.com)
Review
Copy Link

Love this thank you I will take a look

Love this thank you I will take a look

2
app/web/src/index.css
View File

@@ -32,7 +32,7 @@
@layer components {
.tabToggle {
@apply text-ch-gray-300 p-3 mb-3 flex justify-center;
@apply text-ch-gray-300 p-3 mb-1 flex justify-center;
}
.tabToggle.active {
@apply bg-ch-pink-800 text-ch-pink-300 bg-opacity-30;