h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

sync main with release after debugging email verification #371

Merged
Irev-Dev merged 6 commits from release into main 2021-06-19 07:36:05 +02:00
Conversation 6 Commits 6 Files Changed 10 +3 -2
3 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 13b5d9c108 - Show all commits

1
app/api/src/functions/identity-signup.js
View File

@@ -2,6 +2,7 @@ import { createUserInsecure } from 'src/services/users/users.js'
import { db } from 'src/lib/db' import { db } from 'src/lib/db'
import { sentryWrapper } from 'src/lib/sentry' import { sentryWrapper } from 'src/lib/sentry'
import { enforceAlphaNumeric, generateUniqueString } from 'src/services/helpers' import { enforceAlphaNumeric, generateUniqueString } from 'src/services/helpers'
// import 'graphql-tag'
Irev-Dev commented 2021-06-19 03:52:10 +02:00 (Migrated from github.com)
Review
Copy Link

and explicitly requiring this dependency for my signup function

and explicitly requiring this dependency for my signup function
dthyresson commented 2021-06-19 06:14:03 +02:00 (Migrated from github.com)
Review
Copy Link

From: https://community.redwoodjs.com/t/redwood-v0-32/2118/7

Ah - you said the magic word trifecta of Netlify + Functions + Dependency and I wonder if you encountered this: https://www.netlify.com/blog/2021/04/02/modern-faster-netlify-functions/

With the latest release of our function bundler, we’re starting to use esbuild under the hood to handle some parts of this. It also includes an additional step of inlining , where your function code and its dependencies are physically merged into a single file.

The new bundler will be enabled for all projects during the week of May 17, but you can choose to opt-in right now to test the new functionality in public beta and take advantage of the performance improvements immediately.

Perhaps the way Netlify is bundling now wasn't finding that dependency?

And v.0.32 was released on May 14 so ... "week of May 17" does coincide.

Thus make graphql-tag and explicit dependency fixing the issue fits.Thus make graphql-tag and explicit dependency fixing the issue fits.

You can define a list of modules that should be copied to the generated function artifact with their source and references untouched, skipping the inlining and tree-shaking stages. This is useful for handling dependencies that can’t be inlined, such as modules with native addons.

This is done with the external_node_modules property, which you can apply to all functions, or filter some them by name using a wildcard pattern.

# In your netlify.toml
# All functions
[functions]
  external_node_modules = ["module-one", "module-two"]

# Functions with a name starting with "my-function-*"
[functions."my-function-*"]
  external_node_modules = ["module-three", "module-four"]

# A function named "my-function-1"
[functions.my-function-1]
  external_node_modules = ["module-five", "module-six"]
From: https://community.redwoodjs.com/t/redwood-v0-32/2118/7 Ah - you said the magic word trifecta of Netlify + Functions + Dependency and I wonder if you encountered this: https://www.netlify.com/blog/2021/04/02/modern-faster-netlify-functions/ > With the latest release of [our function bundler](https://github.com/netlify/zip-it-and-ship-it), we’re starting to use [esbuild](https://esbuild.github.io/) under the hood to handle some parts of this. It also includes an additional step of *inlining* , where your function code and its dependencies are physically merged into a single file. > The new bundler will be enabled for all projects during the week of May 17, but you can choose to opt-in right now to test the new functionality in public beta and take advantage of the performance improvements immediately. Perhaps the way Netlify is bundling now wasn't finding that dependency? And v.0.32 was released on May 14 so ... "week of May 17" does coincide. Thus `make graphql-tag and explicit dependency` fixing the issue fits.Thus `make graphql-tag and explicit dependency` fixing the issue fits. > You can define a list of modules that should be copied to the generated function artifact with their source and references untouched, skipping the inlining and tree-shaking stages. This is useful for handling dependencies that can’t be inlined, such as modules with native addons. > This is done with the `external_node_modules` property, which you can apply to all functions, or filter some them by name using a [wildcard pattern](https://en.wikipedia.org/wiki/Wildcard_character). ```terminal # In your netlify.toml # All functions [functions] external_node_modules = ["module-one", "module-two"] # Functions with a name starting with "my-function-*" [functions."my-function-*"] external_node_modules = ["module-three", "module-four"] # A function named "my-function-1" [functions.my-function-1] external_node_modules = ["module-five", "module-six"] ```
const unWrappedHandler = async (req, _context) => { const unWrappedHandler = async (req, _context) => {
const body = JSON.parse(req.body) const body = JSON.parse(req.body)

2
app/api/src/services/helpers.js
View File

@@ -20,7 +20,7 @@ export const foreignKeyReplacement = (input) => {
} }
export const enforceAlphaNumeric = (string) => export const enforceAlphaNumeric = (string) =>
string.replace(/([^a-zA-Z\d_:])/g, '-') (string || '').replace(/([^a-zA-Z\d_:])/g, '-')
export const generateUniqueString = async ( export const generateUniqueString = async (
seed, seed,

2
app/api/src/services/parts/parts.js
View File

@@ -83,7 +83,7 @@ export const updatePart = async ({ id, input }) => {
where: { id }, where: { id },
}) })
if (imageToDestroy) { if (imageToDestroy) {
console.log(`image destroyed, publicId: ${imageToDestroy}, partId: ${id}`) // console.log(`image destroyed, publicId: ${imageToDestroy}, partId: ${id}`)
// destroy after the db has been updated // destroy after the db has been updated
destroyImage({ publicId: imageToDestroy }) destroyImage({ publicId: imageToDestroy })
} }