h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

Hook up "Comments" button #83

New Issue
Closed
opened 2020-11-09 08:53:54 +01:00 by Irev-Dev · 0 comments
Irev-Dev commented 2020-11-09 08:53:54 +01:00 (Migrated from github.com)
Copy Link

This button:
image
On the partProfile page has 11 hardcoded and it clicking it doesn't do anything.

  1. 11 needs to be changed to a count of the comments (should be just be Comments.length)
  2. clicking the button should scroll to the comments at the bottom of the page, this can be as simple as adding an id to the comment h3, or using a fancy smooth scrolling library. I don't mind either way, but slighly prefer the first option for simplicity's sake.

File to update is web/src/components/PartProfile/PartProfile.js

This button: ![image](https://user-images.githubusercontent.com/29681384/98513663-53cbe700-22bc-11eb-9c9c-b908aa1ba9ab.png) On the [partProfile page](https://cadhub.xyz/u/irevdev/involute-gears) has `11` hardcoded and it clicking it doesn't do anything. 1) 11 needs to be changed to a count of the comments (should be just be `Comments.length`) 2) clicking the button should scroll to the comments at the bottom of the page, this can be as simple as adding an id to the comment h3, or using a fancy smooth scrolling library. I don't mind either way, but slighly prefer the first option for simplicity's sake. File to update is `web/src/components/PartProfile/PartProfile.js`
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#83
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?