h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

FEAT: Create basic model embed #588

Merged
franknoirot merged 7 commits from feat-embed into main 2022-01-11 07:30:15 +01:00
Conversation 6 Commits 7 Files Changed 16 +290 -58
franknoirot commented 2022-01-09 05:38:30 +01:00 (Migrated from github.com)
Copy Link

Creates a new /embed view for all projects, which shows the viewer with minimal overlays. Makes it possible to embed this view within blog posts via <iframe>, although future work is needed to incorporate the embed markup into the Share modal.

Screen Shot 2022-01-08 at 11 35 13 PM
Creates a new `/embed` view for all projects, which shows the viewer with minimal overlays. Makes it possible to embed this view within blog posts via `<iframe>`, although future work is needed to incorporate the embed markup into the Share modal. <img width="724" alt="Screen Shot 2022-01-08 at 11 35 13 PM" src="https://user-images.githubusercontent.com/23481541/148669659-4ca3b05d-41d7-4a75-ab51-23d17660243a.png">
Irev-Dev commented 2022-01-10 20:31:12 +01:00 (Migrated from github.com)
Copy Link

I'll bring it up here since related to iframe, At one point I had an idea about using a twitter player card for a cadhub experience on twitter #97, but looking at their docs it says "Do not circumvent the intended use of the Card. Player Cards are reserved for linear audio and video consumption only." so I don't know how sketch fab got their player approved.

Maybe I should try and contact twitter's dev support 🤷

I'll bring it up here since related to iframe, At one point I had an idea about using a twitter player card for a cadhub experience on twitter #97, but looking at their [docs](https://developer.twitter.com/en/docs/twitter-for-websites/cards/overview/player-card) it says "Do not circumvent the intended use of the Card. Player Cards are reserved for linear audio and video consumption only." so I don't know how sketch fab got their player approved. Maybe I should try and contact twitter's dev support 🤷
Irev-Dev (Migrated from github.com) requested changes 2022-01-10 20:39:10 +01:00
Irev-Dev (Migrated from github.com) left a comment
Copy Link

Looks good, thanks @franknoirot.

I've asked for two minor changes.

Will merge after those.

Looks good, thanks @franknoirot. I've asked for two minor changes. Will merge after those.
app/web/src/components/EmbedProject/EmbedProject.tsx
Irev-Dev (Migrated from github.com) commented 2022-01-10 20:32:08 +01:00
Copy Link

Could we remove the log?

Could we remove the log?
app/web/src/components/EmbedProjectCell/EmbedProjectCell.tsx
Irev-Dev (Migrated from github.com) commented 2022-01-10 20:36:32 +01:00
Copy Link

You should be able to import than re export QUERY from app/web/src/components/IdeProjectCell/IdeProjectCell.tsx instead of redefining it here (can import the Project type too)
I don't mind having some duplication, but having more than one query with the same name FIND_PROJECT_BY_USENAME_TITLE can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.

You should be able to import than re export QUERY from `app/web/src/components/IdeProjectCell/IdeProjectCell.tsx` instead of redefining it here (can import the Project type too) I don't mind having some duplication, but having more than one query with the same name `FIND_PROJECT_BY_USENAME_TITLE` can cause issues with apollo, if you don't want to import the query could you atleast rename to something unique.
app/web/src/components/IdeViewer/PureIdeViewer.tsx
@@ -214,3 +214,3 @@
src={URL.createObjectURL(image)}
className="h-full w-full"
className="w-full h-full"
/>
Irev-Dev (Migrated from github.com) commented 2022-01-10 20:37:17 +01:00
Copy Link

🙃

🙃
franknoirot commented 2022-01-10 20:53:41 +01:00 (Migrated from github.com)
Copy Link

I'll bring it up here since related to iframe, At one point I had an idea about using a twitter player card for a cadhub experience on twitter #97, but looking at their docs it says "Do not circumvent the intended use of the Card. Player Cards are reserved for linear audio and video consumption only." so I don't know how sketch fab got their player approved.

Maybe I should try and contact twitter's dev support 🤷

Yeah that appears to have been a special partnership that came kind of out of nowhere and doesn't appear to have been repeated, maybe the sort of thing that came from people who work at each company knowing each other or something. But def worth a shot at some point.

> I'll bring it up here since related to iframe, At one point I had an idea about using a twitter player card for a cadhub experience on twitter #97, but looking at their [docs](https://developer.twitter.com/en/docs/twitter-for-websites/cards/overview/player-card) it says "Do not circumvent the intended use of the Card. Player Cards are reserved for linear audio and video consumption only." so I don't know how sketch fab got their player approved. > > Maybe I should try and contact twitter's dev support 🤷 Yeah that appears to have been a special partnership that came kind of out of nowhere and doesn't appear to have been repeated, maybe the sort of thing that came from people who work at each company knowing each other or something. But def worth a shot at some point.
franknoirot (Migrated from github.com) reviewed 2022-01-11 03:07:20 +01:00
app/web/src/components/EmbedProject/EmbedProject.tsx
franknoirot (Migrated from github.com) commented 2022-01-11 03:07:20 +01:00
Copy Link

Complete.

Complete.
franknoirot (Migrated from github.com) reviewed 2022-01-11 03:07:30 +01:00
app/web/src/components/EmbedProjectCell/EmbedProjectCell.tsx
franknoirot (Migrated from github.com) commented 2022-01-11 03:07:30 +01:00
Copy Link

Ah nice thank you, complete.

Ah nice thank you, complete.
Irev-Dev (Migrated from github.com) approved these changes 2022-01-11 07:30:08 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
franknoirot
Irev-Dev
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#588
Delete Branch "feat-embed"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?