"Download STL" should use project title. #568

Closed
opened 2021-10-20 22:16:51 +02:00 by Irev-Dev · 3 comments
Irev-Dev commented 2021-10-20 22:16:51 +02:00 (Migrated from github.com)

When Downloading the STL
image
We try and pull a title from the first comment in the script for the saved file name, this dates back to when did didn't have saved projects, it would be good to use the project title instead.

Changes need to be made in app/web/src/components/EditorMenu/menuConfig.tsx

You should be able to get access to the current project and therefore title with const { project } = useIdeContext(), search for useIdeContext to see where it's imported from.

Make sure the string has .stl suffix on it too!

Follow the instructions in CONTRIBUTING.md to get setup, and of course ask for help here or in the dev-help discord channel.

If you'd like to contribute the CadHub but this issue is taken or you'd prefer something else, have a look at #535 to see if there's something else you would like

When Downloading the STL ![image](https://user-images.githubusercontent.com/29681384/138159159-fb4b70de-5a9f-4854-99f6-b74383bbd085.png) We try and pull a title from the first comment in the script for the saved file name, this dates back to when did didn't have saved projects, it would be good to use the project title instead. Changes need to be made in `app/web/src/components/EditorMenu/menuConfig.tsx` You should be able to get access to the current project and therefore title with `const { project } = useIdeContext()`, search for `useIdeContext` to see where it's imported from. Make sure the string has `.stl` suffix on it too! Follow the instructions in [CONTRIBUTING.md](https://github.com/Irev-Dev/cadhub/blob/main/CONTRIBUTING.md) to get setup, and of course ask for help here or in the [dev-help discord channel](https://discord.gg/Vgmky37UtD). If you'd like to contribute the CadHub but this issue is taken or you'd prefer something else, have a look at #535 to see if there's something else you would like
Irev-Dev commented 2021-10-20 22:23:14 +02:00 (Migrated from github.com)

CC @koodistrom

CC @koodistrom
koodistrom commented 2021-10-21 19:44:27 +02:00 (Migrated from github.com)

Comment for assigning the issue to me 😎

Comment for assigning the issue to me 😎
Irev-Dev commented 2021-11-09 19:25:08 +01:00 (Migrated from github.com)

Resolved by #570

Resolved by #570
Sign in to join this conversation.
No Label
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#568