h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

ImageUploader Userform #56

Merged
Yash-R merged 3 commits from main into main 2020-10-30 09:12:30 +01:00
Conversation 11 Commits 3 Files Changed 4 +27 -22
Yash-R commented 2020-10-30 08:14:53 +01:00 (Migrated from github.com)
Copy Link

Done!

Done!
Irev-Dev commented 2020-10-30 08:49:37 +01:00 (Migrated from github.com)
Copy Link

Thanks @Yash-R

Thanks @Yash-R
Irev-Dev (Migrated from github.com) requested changes 2020-10-30 08:53:33 +01:00
Irev-Dev (Migrated from github.com) left a comment
Copy Link

Not sure about the users.sdl.js, but would like commented out code deleted, please.

Thanks and well done.

Not sure about the users.sdl.js, but would like commented out code deleted, please. Thanks and well done.
api/src/graphql/users.sdl.js
@@ -17,3 +17,3 @@
email: String!
issuer: String!
# issuer: String!
image: String
Irev-Dev (Migrated from github.com) commented 2020-10-30 08:52:54 +01:00
Copy Link

What was happening here, was this causing problems?

What was happening here, was this causing problems?
web/src/components/UserForm/UserForm.js
Irev-Dev (Migrated from github.com) commented 2020-10-30 08:52:20 +01:00
Copy Link

Could you please remove the lines that you commented out?

Could you please remove the lines that you commented out?
Yash-R (Migrated from github.com) reviewed 2020-10-30 08:57:33 +01:00
web/src/components/UserForm/UserForm.js
Yash-R (Migrated from github.com) commented 2020-10-30 08:57:33 +01:00
Copy Link

Okay sure

Okay sure
Yash-R (Migrated from github.com) reviewed 2020-10-30 09:00:21 +01:00
api/src/graphql/users.sdl.js
@@ -17,3 +17,3 @@
email: String!
issuer: String!
# issuer: String!
image: String
Yash-R (Migrated from github.com) commented 2020-10-30 09:00:21 +01:00
Copy Link

Yes, The error was Field "issuer" of required type "String!" was not provided.
The Schema you have created does not use this field.

Yes, The error was Field "issuer" of required type "String!" was not provided. The Schema you have created does not use this field.
Irev-Dev commented 2020-10-30 09:12:49 +01:00 (Migrated from github.com)
Copy Link

Thanks @Yash-R

Thanks @Yash-R
Yash-R commented 2020-10-30 09:16:35 +01:00 (Migrated from github.com)
Copy Link

@Irev-Dev Can you tell me your vision with this project i really liked it.

@Irev-Dev Can you tell me your vision with this project i really liked it.
❤️ 1
Irev-Dev commented 2020-10-30 20:59:07 +01:00 (Migrated from github.com)
Copy Link

@Yash-R Would love to.
There is software called OpenScad, which is a 3d solid modeller that use code to generate its model, different from a more GUI based packages. I have no idea if you familiar with any of this kind of thing, so a good example of a normal cad software would be fusion 360.
OpenScad is by no mean the only code-cad modeler but it is the inspiration for many of them. Besides the fact that it's a neiche community, many developers who want to cad something up (to 3d print or whatever) are really drawn to OpenScad (this counts for me too).
Basically I think that the code-cad community would benefit a lot from a community hub for sharing models and code. What prompted me to begin the project was finding CascadeStudio, it's code-cad package that runs in the browser, allowing for editing models as part of a website, So I've started by integrating it (which is maybe half done, it's still buggy). But depending on if the website gets some tracking it would be good to integrate more.

Have you done any CAD modelling?

@Yash-R Would love to. There is software called OpenScad, which is a 3d solid modeller that use code to generate its model, different from a more GUI based packages. I have no idea if you familiar with any of this kind of thing, so a good example of a normal cad software would be [fusion 360](https://www.autodesk.com/products/fusion-360/personal). OpenScad is by no mean the only code-cad modeler but it is the inspiration for many of them. Besides the fact that it's a neiche community, many developers who want to cad something up (to 3d print or whatever) are really drawn to OpenScad (this counts for me too). Basically I think that the code-cad community would benefit a lot from a community hub for sharing models and code. What prompted me to begin the project was finding [CascadeStudio](https://github.com/zalo/CascadeStudio), it's code-cad package that runs in the browser, allowing for editing models as part of a website, So I've started by integrating it (which is maybe half done, it's still buggy). But depending on if the website gets some tracking it would be good to integrate more. Have you done any CAD modelling?
Yash-R commented 2020-10-30 21:04:39 +01:00 (Migrated from github.com)
Copy Link

No I don't know much about CAD, I'm just a web developer trying to learn more and just wanted to improve myself.

No I don't know much about CAD, I'm just a web developer trying to learn more and just wanted to improve myself.
Irev-Dev commented 2020-10-30 21:08:17 +01:00 (Migrated from github.com)
Copy Link

Yeah cool.
I appreciate your help.
If you're interested in sticking around after hacktoberfest I could make a collaborator on this repo and see what else we can get done.
No obligation.

Yeah cool. I appreciate your help. If you're interested in sticking around after hacktoberfest I could make a collaborator on this repo and see what else we can get done. No obligation.
Yash-R commented 2020-10-31 08:09:12 +01:00 (Migrated from github.com)
Copy Link

Yeah, I would love to collaborate

Yeah, I would love to collaborate
Irev-Dev commented 2020-12-10 09:11:17 +01:00 (Migrated from github.com)
Copy Link

Hey @Yash-R, incase you didn't see my message on discord

Some stickers I ordered finally arrived. Would you like one as a thankyou for your help? (assuming postage doesn't cost me an arm and a leg but should be fine for a sticker).

If you're keen you can send me a DM with your address on twitter or on discord.

unknown

Hey @Yash-R, incase you didn't see my message on discord Some stickers I ordered finally arrived. Would you like one as a thankyou for your help? (assuming postage doesn't cost me an arm and a leg but should be fine for a sticker). If you're keen you can send me a DM with your address on twitter or on discord. ![unknown](https://user-images.githubusercontent.com/29681384/101739294-6a639900-3b1b-11eb-8cd9-b657bcaf1363.png)
❤️ 1
Sign in to join this conversation.
Reviewers
No Reviewers
Irev-Dev
Yash-R
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#56
Delete Branch "main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?