h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

Refactor recent projects into it's own cell #558

Merged
Irev-Dev merged 1 commits from kurt/add-recent-projects into main 2021-10-15 18:35:44 +02:00
Conversation 6 Commits 1 Files Changed 6 +88 -184
Irev-Dev commented 2021-10-15 08:46:14 +02:00 (Migrated from github.com)
Copy Link

I'll leave some more comments on your PR.

I'll leave some more comments on your PR.
franknoirot (Migrated from github.com) reviewed 2021-10-15 08:46:14 +02:00
Irev-Dev (Migrated from github.com) reviewed 2021-10-15 08:52:37 +02:00
app/web/src/components/ProfileSlashLogin/ProfileSlashLogin.tsx
Irev-Dev (Migrated from github.com) commented 2021-10-15 08:52:37 +02:00
Copy Link

bunch of un-used stuff

bunch of un-used stuff
Irev-Dev (Migrated from github.com) reviewed 2021-10-15 08:53:44 +02:00
app/web/src/components/ProjectsCell/ProjectsCell.tsx
@@ -41,3 +31,4 @@
return <div className="rw-text-center">{'No projects yet.'}</div>
}
export const Success = ({
Irev-Dev (Migrated from github.com) commented 2021-10-15 08:53:44 +02:00
Copy Link

I don't think this makes sense since it defaults to OpenSCAD and I don't think we should assume everyone wants to start a scad project

I don't think this makes sense since it defaults to OpenSCAD and I don't think we should assume everyone wants to start a scad project
Irev-Dev (Migrated from github.com) reviewed 2021-10-15 08:54:48 +02:00
app/web/src/components/RecentProjectsCell/RecentProjectsCell.tsx
@@ -0,0 +2,4 @@
import type { Projects_Of_User } from 'types/graphql'
import { Link, routes } from '@redwoodjs/router'
import { QUERY as _QUERY } from 'src/components/ProjectsOfUserCell/ProjectsOfUserCell'
Irev-Dev (Migrated from github.com) commented 2021-10-15 08:54:48 +02:00
Copy Link

I tried export { QUERY } from 'src/components/ProjectsOfUserCell/ProjectsOfUserCell' as that's valid syntax, but no luck.

I tried `export { QUERY } from 'src/components/ProjectsOfUserCell/ProjectsOfUserCell'` as that's valid syntax, but no luck.
Irev-Dev commented 2021-10-15 19:13:25 +02:00 (Migrated from github.com)
Copy Link

Live now

Live now
🚀 1
franknoirot commented 2021-10-16 02:47:57 +02:00 (Migrated from github.com)
Copy Link

Oh shoot @Irev-Dev I'm sorry I don't know why I totally missed the notification on this!

Oh shoot @Irev-Dev I'm sorry I don't know why I totally missed the notification on this!
👍 1
Sign in to join this conversation.
Reviewers
No Reviewers
franknoirot
Irev-Dev
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#558
Delete Branch "kurt/add-recent-projects"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?