h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

Delete project properly as it's not causing problems with forking logic #539

Merged
Irev-Dev merged 1 commits from kurt/delete-projects-properly into main 2021-09-29 11:04:35 +02:00
Conversation 1 Commits 1 Files Changed 1 +12 -6
Irev-Dev commented 2021-09-29 11:03:57 +02:00 (Migrated from github.com)
Copy Link

Going to go ahead and merge since it could cause problem on prod.

prisma still doesn't support defining cascade deletion rule in their schemas, hopefully they will eventually, but for now I'm just deleting all children before attempting to delete the project (other wish it errors because a comment can't exist without a project etc).

things to clean up later is to remove the deleted property on projects and delete and projects that have that set to true

Going to go ahead and merge since it could cause problem on prod. prisma still doesn't support defining cascade deletion rule in their schemas, hopefully they will eventually, but for now I'm just deleting all children before attempting to delete the project (other wish it errors because a comment can't exist without a project etc). things to clean up later is to remove the deleted property on projects and delete and projects that have that set to true
Irev-Dev commented 2021-09-29 11:13:06 +02:00 (Migrated from github.com)
Copy Link

Live now

Live now
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#539
Delete Branch "kurt/delete-projects-properly"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?