h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

Fix JSCAD STL download #528

Merged
Irev-Dev merged 1 commits from kurt/fix-JSCAD-download into main 2021-09-24 09:59:10 +02:00
Conversation 2 Commits 1 Files Changed 3 +49 -46
Irev-Dev commented 2021-09-23 23:59:41 +02:00 (Migrated from github.com)
Copy Link

JSCAD STL download wasn't working, because I had broke it :(

JSCAD STL download wasn't working, because I had broke it :(
hrgdavor (Migrated from github.com) approved these changes 2021-09-24 00:22:00 +02:00
hrgdavor (Migrated from github.com) left a comment
Copy Link

Tested it and it works. Can't comment much on the changes, looks like some refactoring. Your code is cleaner than mine, so I have not complaints on that :)

Tested it and it works. Can't comment much on the changes, looks like some refactoring. Your code is cleaner than mine, so I have not complaints on that :)
Irev-Dev commented 2021-09-24 22:35:43 +02:00 (Migrated from github.com)
Copy Link

Live now

Live now
Sign in to join this conversation.
Reviewers
No Reviewers
hrgdavor
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#528
Delete Branch "kurt/fix-JSCAD-download"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?