h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

Show empty KeyValue's if editing #526

Merged
franknoirot merged 2 commits from bugfix-525 into main 2021-09-23 10:51:45 +02:00
Conversation 3 Commits 2 Files Changed 2 +53 -11
franknoirot commented 2021-09-23 05:21:32 +02:00 (Migrated from github.com)
Copy Link

Begins #525, although more gaps in the profile validation have been found.

@Irev-Dev one interesting issue I ran into with the Bio Markdown editor is that when I tried to set my bio to nothing it still kept around an invisible newline character (value was \\n in Prisma Studio), so the bio always appeared after editing once, even after trying to delete it.

I suppose this is a vanishingly rare case though, where someone took the time to write a profile at one point but now definitely wants no bio, right? 🤷🏻‍♂️

Begins #525, although more gaps in the profile validation have been found. @Irev-Dev one interesting issue I ran into with the `Bio` Markdown editor is that when I tried to set my bio to nothing it still kept around an invisible newline character (value was `\\n` in Prisma Studio), so the bio always appeared after editing once, even after trying to delete it. I suppose this is a vanishingly rare case though, where someone took the time to write a profile at one point but now definitely wants no bio, right? 🤷🏻‍♂️
franknoirot commented 2021-09-23 05:22:36 +02:00 (Migrated from github.com)
Copy Link

We can also revert this to a Draft if you want more lines of code in this PR and to address the other validation issues I noted in #525 alongside.

We can also revert this to a Draft if you want more lines of code in this PR and to address the other validation issues I noted in #525 alongside.
Irev-Dev (Migrated from github.com) approved these changes 2021-09-23 10:50:57 +02:00
Irev-Dev (Migrated from github.com) left a comment
Copy Link

Thanks @franknoirot, Good pick up with some of the other issues, I fixed a few but will reply on the issue.

Thanks @franknoirot, Good pick up with some of the other issues, I fixed a few but will reply on the issue.
Irev-Dev commented 2021-09-23 11:15:07 +02:00 (Migrated from github.com)
Copy Link

Live now

Live now
🚀 1
Sign in to join this conversation.
Reviewers
No Reviewers
Irev-Dev
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#526
Delete Branch "bugfix-525"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?