h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

Add code backdrops to homepage #522

Merged
Irev-Dev merged 1 commits from kurt/add-code-backdrops-to-home-page into main 2021-09-23 10:14:06 +02:00
Conversation 4 Commits 1 Files Changed 2 +198 -141
Irev-Dev commented 2021-09-21 09:58:23 +02:00 (Migrated from github.com)
Copy Link

Not the easiest diff to read, the reason the diff is so big is because I change the approach to the canvas, earlier it was an entire horizontal bar of canvas with html on top, now the canvas fits into the css grid. means I can just put the asset in the middle of the canvas and place it with css into the grid, also makes adjusting for break points easier.

I just made a quick svg to use as a clip path for the code blob.

if you look at the diff, turn whitespace off.

image
image

Not the easiest diff to read, the reason the diff is so big is because I change the approach to the canvas, earlier it was an entire horizontal bar of canvas with html on top, now the canvas fits into the css grid. means I can just put the asset in the middle of the canvas and place it with css into the grid, also makes adjusting for break points easier. I just made a quick svg to use as a clip path for the code blob. if you look at the diff, turn whitespace off. ![image](https://user-images.githubusercontent.com/29681384/134136012-807dcf16-6bca-4b55-b866-abba8ac6c4c1.png) ![image](https://user-images.githubusercontent.com/29681384/134136055-811e10d5-e9f7-48e1-b26c-027fbb60e067.png)
Irev-Dev (Migrated from github.com) reviewed 2021-09-21 10:04:49 +02:00
app/web/src/components/Hero/Hero.tsx
@@ -36,0 +39,4 @@
.loft()
.translate([0, 0, h1])
)
`.split('\n')
Irev-Dev (Migrated from github.com) commented 2021-09-21 10:04:48 +02:00
Copy Link

this was used to move the asset in 3d when screen size changes and can be removed now.

this was used to move the asset in 3d when screen size changes and can be removed now.
Irev-Dev (Migrated from github.com) reviewed 2021-09-21 10:07:31 +02:00
app/web/src/components/Hero/Hero.tsx
@@ -109,0 +140,4 @@
>
Code
</span>
</div>
Irev-Dev (Migrated from github.com) commented 2021-09-21 10:07:31 +02:00
Copy Link

lots of grid start span etc stuff since I'm forcing much of the content to overlap, and then needs to adjust for smaller screens too.

lots of `grid` `start` `span` etc stuff since I'm forcing much of the content to overlap, and then needs to adjust for smaller screens too.
franknoirot (Migrated from github.com) approved these changes 2021-09-23 05:53:31 +02:00
franknoirot (Migrated from github.com) left a comment
Copy Link

Nice! I got to verify the look as part of the other PR. And GH did a solid job of making the diff readable on my phone.

Nice! I got to verify the look as part of the other PR. And GH did a solid job of making the diff readable on my phone.
Irev-Dev commented 2021-09-23 11:15:30 +02:00 (Migrated from github.com)
Copy Link

Live now

Live now
Sign in to join this conversation.
Reviewers
No Reviewers
Irev-Dev
franknoirot
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#522
Delete Branch "kurt/add-code-backdrops-to-home-page"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?