h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

Improve three scene performance and add JSCAD #506

Merged
Irev-Dev merged 1 commits from kurt/three-perf-n-tweaks-rebase into main 2021-09-12 06:52:08 +02:00
Conversation 9 Commits 1 Files Changed 17 +6735 -34917
Irev-Dev commented 2021-09-12 06:43:37 +02:00 (Migrated from github.com)
Copy Link

Also

  • smoothed follow mouse animation
  • made mobile friendlier down to about 330px ish
  • added default social image
  • used smaller hero asset

requires yarn rw prisma migrate dev for local dev because of db changes.

Also - smoothed follow mouse animation - made mobile friendlier down to about 330px ish - added default social image - used smaller hero asset requires `yarn rw prisma migrate dev` for local dev because of db changes.
Irev-Dev (Migrated from github.com) reviewed 2021-09-12 06:44:04 +02:00
app/api/db/schema.prisma
Irev-Dev (Migrated from github.com) commented 2021-09-12 06:44:04 +02:00
Copy Link

Hooraa @hrgdavor

Hooraa @hrgdavor
Irev-Dev (Migrated from github.com) reviewed 2021-09-12 06:44:30 +02:00
app/web/src/components/Hero/AssetWithGooey.tsx
@@ -78,3 +70,3 @@
function Gooey() {
const blobsData = useMemo(() => {
const firstSet = Array.from({ length: 10 }).map((_, index) => {
const firstSet = Array.from({ length: 5 }).map((_, index) => {
Irev-Dev (Migrated from github.com) commented 2021-09-12 06:44:30 +02:00
Copy Link

This alone was a big perf improvement

This alone was a big perf improvement
Irev-Dev (Migrated from github.com) reviewed 2021-09-12 06:45:02 +02:00
app/web/src/components/Hero/AssetWithGooey.tsx
Irev-Dev (Migrated from github.com) commented 2021-09-12 06:45:01 +02:00
Copy Link

adding some roughness the the blobs for perf

adding some roughness the the blobs for perf
Irev-Dev (Migrated from github.com) reviewed 2021-09-12 06:45:18 +02:00
app/web/src/components/Hero/AssetWithGooey.tsx
Irev-Dev (Migrated from github.com) commented 2021-09-12 06:45:18 +02:00
Copy Link

reducing the number of blobs also helped perf

reducing the number of blobs also helped perf
Irev-Dev (Migrated from github.com) reviewed 2021-09-12 06:46:08 +02:00
app/web/src/components/Hero/Hero.tsx
Irev-Dev (Migrated from github.com) commented 2021-09-12 06:46:08 +02:00
Copy Link

I liked the reflection from <Environment /> so this replicates that a little

I liked the reflection from `<Environment />` so this replicates that a little
Irev-Dev (Migrated from github.com) reviewed 2021-09-12 06:47:15 +02:00
app/web/src/pages/HomePage/HomePage.tsx
@@ -9,6 +9,7 @@ const ProjectsPage = () => {
title="Home page"
description="Learn about Code CAD and the CadHub community"
lang="en-US"
socialImageUrl="https://cadhub.xyz/default-social-image.jpg"
Irev-Dev (Migrated from github.com) commented 2021-09-12 06:47:15 +02:00
Copy Link

for now its:
default-social-image

for now its: ![default-social-image](https://user-images.githubusercontent.com/29681384/132972540-49c0e764-825d-4ef2-b901-b0b9d4e04daf.jpg)
Irev-Dev (Migrated from github.com) reviewed 2021-09-12 06:48:22 +02:00
app/web/src/layouts/MainLayout/MainLayout.js
Irev-Dev (Migrated from github.com) commented 2021-09-12 06:48:21 +02:00
Copy Link

See https://github.com/Irev-Dev/cadhub/pull/505#issuecomment-917548915

See https://github.com/Irev-Dev/cadhub/pull/505#issuecomment-917548915
Irev-Dev (Migrated from github.com) reviewed 2021-09-12 06:51:44 +02:00
app/web/src/components/Hero/AssetWithGooey.tsx
Irev-Dev (Migrated from github.com) commented 2021-09-12 06:51:44 +02:00
Copy Link

this makes the follow animation smoother by magic,

I just copy pasted it from an example so not fully on top of it, but I know that 'lerp' is linear interpolation, so uses that to gradually rotate the model.

this makes the follow animation smoother by magic, I just copy pasted it from an example so not fully on top of it, but I know that 'lerp' is linear interpolation, so uses that to gradually rotate the model.
Irev-Dev (Migrated from github.com) reviewed 2021-09-12 06:57:22 +02:00
app/web/package.json
@@ -43,6 +43,7 @@
"react-helmet": "^6.1.0",
"react-hotkeys-hook": "^3.4.0",
"react-image-crop": "^8.6.6",
"react-intersection-observer": "^8.32.1",
Irev-Dev (Migrated from github.com) commented 2021-09-12 06:57:22 +02:00
Copy Link

used to turn off the canvas when not visible

used to turn off the canvas when not visible
Sign in to join this conversation.
Reviewers
No Reviewers
Irev-Dev
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#506
Delete Branch "kurt/three-perf-n-tweaks-rebase"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?