h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

minor style tweaks to editor #497

Merged
franknoirot merged 2 commits from franknoirot/style-tweaks into main 2021-09-08 23:23:29 +02:00
Conversation 6 Commits 2 Files Changed 9 +21 -23
franknoirot commented 2021-09-08 08:58:19 +02:00 (Migrated from github.com)
Copy Link

Changes:

  • Updated base font to be Fira Sans unless otherwise specified
  • Updated Gear icon to one with less spokes that I revised within the Figma designs
  • Tweaked the size of things to bring them down just a hair:
    • sidebar width
    • drag icon widths
    • gear icons
  • Added blue to the Capture Image button. This might better live in the sidebar someday, but I thought it could look good with blue in the header for now.
  • Added a hover state to the plus button in the header
**Changes:** - Updated base font to be Fira Sans unless otherwise specified - Updated Gear icon to one with less spokes that I revised within the Figma designs - Tweaked the size of things to bring them down just a hair: - sidebar width - drag icon widths - gear icons - Added blue to the Capture Image button. This might better live in the sidebar someday, but I thought it could look good with blue in the header for now. - Added a hover state to the plus button in the header
franknoirot (Migrated from github.com) reviewed 2021-09-08 09:02:17 +02:00
app/web/src/components/Svg/Svg.tsx
@@ -331,21 +330,12 @@ const Svg = ({
</svg>
franknoirot (Migrated from github.com) commented 2021-09-08 09:00:30 +02:00
Copy Link

If the IdeSidebar is the only place that big-gear is used we can probably do away with it; they're the same SVG now.

If the `IdeSidebar` is the only place that `big-gear` is used we can probably do away with it; they're the same SVG now.
app/web/src/index.css
@@ -15,1 +15,4 @@
@layer base {
body {
font-family: 'Fira Sans', ui-sans-serif, system-ui, -apple-system, system-ui, "Segoe UI", "Helvetica Neue", Arial, "Noto Sans", sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji";
franknoirot (Migrated from github.com) commented 2021-09-08 09:02:08 +02:00
Copy Link

I basically prepended Fira Sans to the default font stack, but unsure if that is unwise for some reason like unnecessary fonts being loaded. I don't think that happens with CSS though.

I basically prepended Fira Sans to the default font stack, but unsure if that is unwise for some reason like unnecessary fonts being loaded. I don't think that happens with CSS though.
Irev-Dev (Migrated from github.com) reviewed 2021-09-08 10:11:50 +02:00
app/web/src/components/Svg/Svg.tsx
@@ -331,21 +330,12 @@ const Svg = ({
</svg>
Irev-Dev (Migrated from github.com) commented 2021-09-08 10:11:50 +02:00
Copy Link

Yup 👍 , I added it for the side bar so shouldn't be used anywhere else.

Yup 👍 , I added it for the side bar so shouldn't be used anywhere else.
Irev-Dev (Migrated from github.com) reviewed 2021-09-08 10:12:38 +02:00
app/web/src/index.css
@@ -15,1 +15,4 @@
@layer base {
body {
font-family: 'Fira Sans', ui-sans-serif, system-ui, -apple-system, system-ui, "Segoe UI", "Helvetica Neue", Arial, "Noto Sans", sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji";
Irev-Dev (Migrated from github.com) commented 2021-09-08 10:12:38 +02:00
Copy Link

This is good.

This is good.
Irev-Dev (Migrated from github.com) approved these changes 2021-09-08 10:13:39 +02:00
Irev-Dev (Migrated from github.com) left a comment
Copy Link

Thanks 😄

Should I merge now or do you want to remove 'big-gear'?

Thanks 😄 Should I merge now or do you want to remove 'big-gear'?
franknoirot commented 2021-09-08 16:45:37 +02:00 (Migrated from github.com)
Copy Link

@Irev-Dev I removed big-gear so it should be ready if you're happy with it!

@Irev-Dev I removed big-gear so it should be ready if you're happy with it!
👍 1
Irev-Dev commented 2021-09-09 11:06:26 +02:00 (Migrated from github.com)
Copy Link

Live now.

Live now.
Sign in to join this conversation.
Reviewers
No Reviewers
franknoirot
Irev-Dev
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#497
Delete Branch "franknoirot/style-tweaks"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?