1/3 for customizer is plenty #473

2021-08-23T14:16:12+02:00

hrgdavor commented

2021-08-23 14:16:12 +02:00

(Migrated from github.com)

open for discussion ofc, but 2/3 was too much

Irev-Dev (Migrated from github.com) requested changes 2021-08-24 09:33:44 +02:00

app/web/src/components/Customizer/Customizer.tsx

Irev-Dev (Migrated from github.com) commented

2021-08-24 09:33:26 +02:00

I get the gist, but on small screens 1/3 is too small, the point of expanding the parameters for it to expand. how about the following instead?

        open ? 'h-full max-h-96' : ''

The other thing I quickly experimented with was using pointer-events: none on the upper most div in the customiser panel, this allows navigating around the scene with the orbit/drag controls through the customizer panel, the idea being if you can still navigate in the scene, the panel is being less obtrusive.

however it also stops scroll events which is a non-starter since the panel needs to be able to scroll.

I get the gist, but on small screens 1/3 is too small, the point of expanding the parameters for it to expand. how about the following instead? ```suggestion open ? 'h-full max-h-96' : '' ``` The other thing I quickly experimented with was using `pointer-events: none` on the upper most div in the customiser panel, this allows navigating around the scene with the orbit/drag controls through the customizer panel, the idea being if you can still navigate in the scene, the panel is being less obtrusive. however it also stops scroll events which is a non-starter since the panel needs to be able to scroll.

hrgdavor (Migrated from github.com) reviewed 2021-08-24 10:08:02 +02:00

app/web/src/components/Customizer/Customizer.tsx

hrgdavor (Migrated from github.com) commented

2021-08-24 10:08:02 +02:00

ok, h-full max-h-96 is much better, I was looking for sth like that, but I do not know tailwind, so I started this PR so we can have a better size definition

ok, `h-full max-h-96` is much better, I was looking for sth like that, but I do not know tailwind, so I started this PR so we can have a better size definition

hrgdavor (Migrated from github.com) reviewed 2021-08-24 10:09:08 +02:00

app/web/src/components/Customizer/Customizer.tsx

hrgdavor (Migrated from github.com) commented

2021-08-24 10:09:08 +02:00

just noticed , btu ferw seconds too late ... cool feature for colab on PR

just noticed , btu ferw seconds too late ... cool feature for colab on PR ![image](https://user-images.githubusercontent.com/2480762/130580893-8cd62821-9ada-450c-97dc-88d350c3bc84.png)

Irev-Dev (Migrated from github.com) approved these changes 2021-08-24 10:37:16 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: h3n3/cadhub#473