h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

better default script #471

Merged
hrgdavor merged 1 commits from jscad-new-default-script into main 2021-08-24 10:36:58 +02:00
Conversation 2 Commits 1 Files Changed 2 +222 -45
hrgdavor commented 2021-08-23 11:59:39 +02:00 (Migrated from github.com)
Copy Link

created a better default script-

This is direction I want to go

  • it should not be too large so user has to delete a lot to get started
  • showcase few things
  • has few links to API docs
  • has few parameters to show customizer

parameter extraction form script source code is not yet in jscad master, so I added it into worker directly.

created a better default script- This is direction I want to go - it should not be too large so user has to delete a lot to get started - showcase few things - has few links to API docs - has few parameters to show customizer parameter extraction form script source code is not yet in jscad master, so I added it into worker directly.
Irev-Dev (Migrated from github.com) approved these changes 2021-08-24 09:26:57 +02:00
Irev-Dev (Migrated from github.com) left a comment
Copy Link

Nice,
Would you be able to include a screen shot of the part?

Just FYI, If we get to the point where we're happy to release the JSCAD integration but the "parameter extraction" hasn't made it into JSCAD master I might quickly swap the params back to the definitions export just so that it complies with master, but 🤞 won't have to. Is that okay with you?

Nice, Would you be able to include a screen shot of the part? Just FYI, If we get to the point where we're happy to release the JSCAD integration but the "parameter extraction" hasn't made it into JSCAD master I might quickly swap the params back to the definitions export just so that it complies with master, but 🤞 won't have to. Is that okay with you?
hrgdavor commented 2021-08-24 10:11:21 +02:00 (Migrated from github.com)
Copy Link

Would you be able to include a screen shot of the part?

not sure I get what u mean here :)

Just FYI, If we get to the point where we're happy to release the JSCAD integration but the "parameter extraction" hasn't made it into JSCAD master I might quickly swap the params back to the definitions export just so that it complies with master, but 🤞 won't have to. Is that okay with you?

That is ok with me, that PR is waiting final approval, but will very likely be ready when JSCAD is officialy integrated into cadhub

> Would you be able to include a screen shot of the part? not sure I get what u mean here :) > Just FYI, If we get to the point where we're happy to release the JSCAD integration but the "parameter extraction" hasn't made it into JSCAD master I might quickly swap the params back to the definitions export just so that it complies with master, but 🤞 won't have to. Is that okay with you? That is ok with me, that PR is waiting final approval, but will very likely be ready when JSCAD is officialy integrated into cadhub
Sign in to join this conversation.
Reviewers
No Reviewers
Irev-Dev
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#471
Delete Branch "jscad-new-default-script"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?