h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

make z axis up and other viewer improvements #446

Merged
Irev-Dev merged 4 commits from kurt/make-z-axis-up-444 into main 2021-08-09 23:31:07 +02:00
Conversation 2 Commits 4 Files Changed 7 +227 -225
Irev-Dev commented 2021-08-09 22:54:28 +02:00 (Migrated from github.com)
Copy Link
  • make Z axis up
  • add grid
  • split normals
  • resync openscad camera with three camera
  • fix stl download for CQ and openscad
  • clean up failed preview image attempt

split normals is there to smooth surfaces
image
doesn't apply to jscad.
something i still want to solve is to stop edges from blending into each other.
image
Not sure what needs to be done. maybe it's that the material needs to cast and receive shadows? anyway something for another PR

Related to #444

- make Z axis up - add grid - split normals - resync openscad camera with three camera - fix stl download for CQ and openscad - clean up failed preview image attempt split normals is there to smooth surfaces ![image](https://user-images.githubusercontent.com/29681384/128772613-bf069b0a-39b3-4910-b114-55d25161ed65.png) doesn't apply to jscad. something i still want to solve is to stop edges from blending into each other. ![image](https://user-images.githubusercontent.com/29681384/128772784-f80c5950-4ffa-4932-8d78-41650cdb5c45.png) Not sure what needs to be done. maybe it's that the material needs to cast and receive shadows? anyway something for another PR Related to #444
franknoirot (Migrated from github.com) reviewed 2021-08-09 22:54:28 +02:00
hrgdavor (Migrated from github.com) approved these changes 2021-08-09 23:27:13 +02:00
hrgdavor (Migrated from github.com) left a comment
Copy Link

Code looks good. jscad IDE works fine.
Yeah, I prefer edgeSplit is not used on jscad models, at least for now.

Tested on Win 11 & Chrome

Code looks good. jscad IDE works fine. Yeah, I prefer edgeSplit is not used on jscad models, at least for now. Tested on Win 11 & Chrome
Sign in to join this conversation.
Reviewers
No Reviewers
franknoirot
hrgdavor
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#446
Delete Branch "kurt/make-z-axis-up-444"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?