h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

jscad customizer with non-react component #440

Merged
hrgdavor merged 22 commits from kurt/customizer-start-320 into main 2021-08-07 23:09:27 +02:00
Conversation 3 Commits 22 Files Changed 15 +576 -42
hrgdavor commented 2021-08-06 11:23:29 +02:00 (Migrated from github.com)
Copy Link

Implementation of parameters to match jscad spec, to be used until a nicer react component replaces it.

Implementation of parameters to match jscad spec, to be used until a nicer react component replaces it.
hrgdavor commented 2021-08-06 12:36:57 +02:00 (Migrated from github.com)
Copy Link

I see that you formated code, what are you using to do it ?
so I can do it before PR

I see that you formated code, what are you using to do it ? so I can do it before PR
Irev-Dev commented 2021-08-06 22:27:07 +02:00 (Migrated from github.com)
Copy Link

I see that you formated code, what are you using to do it ?
so I can do it before PR

yarn rw lint --fix 👍

> I see that you formated code, what are you using to do it ? > so I can do it before PR `yarn rw lint --fix` 👍
Irev-Dev (Migrated from github.com) approved these changes 2021-08-07 13:36:46 +02:00
Irev-Dev (Migrated from github.com) left a comment
Copy Link

Im done with my changes and happy to merge at this point, but since i did make changes I'll wait until your happy with ti before i merge.

I think i resolved the issue between full re-render and caching for params but of course make any changes you need to.

Im done with my changes and happy to merge at this point, but since i did make changes I'll wait until your happy with ti before i merge. I think i resolved the issue between full re-render and caching for params but of course make any changes you need to.
Sign in to join this conversation.
Reviewers
No Reviewers
Irev-Dev
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#440
Delete Branch "kurt/customizer-start-320"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?