Safari styling errors #435
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I've largely neglected safari and the result is there are a bunch of styling problems
Z issues for the login modal
lots of flex gaps ignored by the browser and the page leaves a gap at the bottom of the page.
More ignored gaps.
found by @revolter.
yup so safari just ignores flex gaps until this year, but we probably need to refactor using padding to support older safari.
https://css-tricks.com/safari-14-1-adds-support-for-flexbox-gaps/
Because this is all style related it would be a good first issue for someone, especially if you've used tailwind before.
Wait this is a terrible issue for you right @franknoirot? don't you run Windows?
@Irev-Dev I've got a MacBook for work so I think I can do it alright!
Perfect.
@Irev-Dev confirmed I've been able to get my dev environment in order and use Redwood's forwarding dev command to open the site running locally from my work computer in Safari. On the hunt for some solutions, think I understand the
z-indexissue and will investigate the rest tomorrow.Okay so the problem with the gaps is that the
gapCSS property is only supported in the absolute latest Safari version, which up until now only supportedgapor the formergrid-gapfor elements withdisplay: gridand no gap-like property for elements with `display: flex'.Typically you could use an
@supports (gap: 1rem)statement to detect if a browser supports a CSS property, but you can't in this case because it's a two condition support statement targeting Safari: supportinggap: 1remin tandem withdisplay: flex. This has sparked some fascinating discussion on the W3C CCSWG even though this particular iteration of the problem will go away as Safari users upgrade.In the meantime, there is no CSS-only fix for this solution. As noted in the CSSWG thread, Ahmad Shadeed published a JS solution for detecting support in this blog post that explains the detection issue.
Nice investigative work @franknoirot 🕵️ ,
I was thinking that we would solve this simply by replacing the gap class currently on the parent with padding/margin on the children, bit of a pain but also very straight forward?
Or do you think that a more sophisticated solution detecting the problem and adjusting is called for?
Actually would using grid instead of flex work in most of our cases? I don't think we're using flex specific features (like grow/shrink) so maybe that would work?
https://twitter.com/fra_michelini/status/1425023649069867009
@Irev-Dev yeah I'd like to see where I can get away with just converting from
flextogridand the like.One potential reason for using the more bloated detection patch is we can remove that once support is widespread enough and have the best practice already sitting there. And since
flexcontainers don't have collapsing margins any margin we add to their children could cause misalignment due to margins on the first and last children being applied that we would have to override, and I'm not sure if there are Tailwind classes for child selectors so those overrides will likely be custom styles anyway. But I'll do some research tonight.Ugh @Irev-Dev I ran into a problem tonight. At work we keep our laptops up-to-date with the latest iOS (I'm running 14.5) and you can't downgrade, so I'm not able to recreate the
gapissue. I'm trying to emulate older versions of Safari using XCode (I downloaded iOS 13.5 Simulator), but you can't use that to simulate desktop Safari, only iPad and other mobile devices.I have been able to confirm that replacing
gapTailwindCSS class names with one-sided margins on all but the first/last children is a good replacement that looks the same in other browsers, but I can't recreate the environment to see all of the issues for real right now.Do you know of a reliable way to emulate old desktop Safari versions?
One good thing I will say is everything looks great on latest Safari haha, even that height issue with the IDE page is gone for me.
@franknoirot, but can you reproduce this:
?
It happens for me in Safari 14.1.2 (16611.3.10.1.3).
@revolter yup I can replace that! I've committed a fix to it in
68346e075aOooh, I see now. I don't experience the gap issues either.
Unless you really want to see this issue to the end @franknoirot, I might as well fix the gap issue since I still got the old version on my machine.
Good that the rest of the issues in the IDE are okay in the new version.
Only done one so far but its looking promising
Nice! Appreciate it.