h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

set up local development for openscad lamdas #232

Merged
Irev-Dev merged 1 commits from kurt/227 into main 2021-03-10 09:04:37 +01:00
Conversation 3 Commits 1 Files Changed 13 +4613 -3490
Irev-Dev commented 2021-03-09 22:18:48 +01:00 (Migrated from github.com)
Copy Link

and make a start on combining with Three.js IdeViewer

Long story short, I've made progress getting the viewer working, but struggling to convert between the cordinate systems of Three.js and openscad, so I'm not able to update the camera between two to keep them in sync. I probably just need to learn a bit more about 3d math. But what I'm thinking is lets get this merged, then I'll do an deploy so that /dev-ide is live and I'll probably jump on a couple of forums asking for advice, that way I can point them at what we're trying to do which may help.

Resolves #227
Related #231

and make a start on combining with Three.js IdeViewer Long story short, I've made progress getting the viewer working, but struggling to convert between the cordinate systems of Three.js and openscad, so I'm not able to update the camera between two to keep them in sync. I probably just need to learn a bit more about 3d math. But what I'm thinking is lets get this merged, then I'll do an deploy so that `/dev-ide` is live and I'll probably jump on a couple of forums asking for advice, that way I can point them at what we're trying to do which may help. Resolves #227 Related #231
Irev-Dev (Migrated from github.com) reviewed 2021-03-09 22:21:10 +01:00
web/src/helpers/cadPackages/openScadController.js
@@ -14,3 +18,1 @@
},
file: code,
}),
headers: {
Irev-Dev (Migrated from github.com) commented 2021-03-09 22:21:10 +01:00
Copy Link

express did not like this new Hearders business, and aws seems to be fine with regular json so I've changed it 🤷

express did not like this `new Hearders` business, and aws seems to be fine with regular json so I've changed it 🤷
Irev-Dev (Migrated from github.com) reviewed 2021-03-09 22:22:11 +01:00
web/src/components/IdeViewer/IdeViewer.js
@@ -1,25 +1,133 @@
import { useContext } from 'react'
import { IdeContext } from 'src/components/IdeToolbarNew'
import { useRef, useState, useEffect, useContext, useMemo } from 'react'
import { Canvas, extend, useFrame, useThree } from 'react-three-fiber'
Irev-Dev (Migrated from github.com) commented 2021-03-09 22:22:10 +01:00
Copy Link

This file is becoming pretty coupled to openscad, but I'm in the "get it working" stage. I'll try and seperate concerns after.

This file is becoming pretty coupled to openscad, but I'm in the "get it working" stage. I'll try and seperate concerns after.
franknoirot (Migrated from github.com) approved these changes 2021-03-10 01:59:35 +01:00
franknoirot (Migrated from github.com) left a comment
Copy Link

Oh nice I get it! Very cool.

Oh nice I get it! Very cool.
Sign in to join this conversation.
Reviewers
No Reviewers
Irev-Dev
franknoirot
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#232
Delete Branch "kurt/227"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?