h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

Update logo around the website #108

Merged
Irev-Dev merged 1 commits from kurt/issue-107 into main 2020-11-18 07:47:28 +01:00
Conversation 5 Commits 1 Files Changed 10 +194 -43
Irev-Dev commented 2020-11-17 21:57:31 +01:00 (Migrated from github.com)
Copy Link

updated the favicon with a webpack plugin, as will as on the MainLayout
Plus some other tweaks to the main layout while I was there

resolves #107

image

updated the favicon with a webpack plugin, as will as on the MainLayout Plus some other tweaks to the main layout while I was there resolves #107 ![image](https://user-images.githubusercontent.com/29681384/99449807-fb5bb000-2973-11eb-854d-1c64ace911ca.png)
Yash-R (Migrated from github.com) reviewed 2020-11-17 21:57:31 +01:00
Irev-Dev (Migrated from github.com) reviewed 2020-11-17 22:01:01 +01:00
web/src/layouts/MainLayout/MainLayout.js
Irev-Dev (Migrated from github.com) commented 2020-11-17 22:01:01 +01:00
Copy Link

Added this back as there is no gravatar to show when the user is not signed in.
Also makes it clearer for users who are yet to signup
image

Added this back as there is no gravatar to show when the user is not signed in. Also makes it clearer for users who are yet to signup ![image](https://user-images.githubusercontent.com/29681384/99449957-30680280-2974-11eb-8d6c-46ddeeaf4098.png)
Irev-Dev (Migrated from github.com) reviewed 2020-11-17 22:01:36 +01:00
web/src/layouts/MainLayout/MainLayout.js
@@ -115,0 +117,4 @@
</li>
) : (
<li>
<a
Irev-Dev (Migrated from github.com) commented 2020-11-17 22:01:36 +01:00
Copy Link

border got changed from border-2 to border-1, which isn't actually a tailwind class.

border got changed from border-2 to border-1, which isn't actually a tailwind class.
Yash-R (Migrated from github.com) reviewed 2020-11-18 07:00:28 +01:00
web/src/layouts/MainLayout/MainLayout.js
Yash-R (Migrated from github.com) commented 2020-11-18 07:00:28 +01:00
Copy Link

When the user is not loggedin we can also make something like this.

Screenshot (21)

and when the user would be loggedin then we can show his own avatar?
What say @Irev-Dev

When the user is not loggedin we can also make something like this. ![Screenshot (21)](https://user-images.githubusercontent.com/41328269/99491118-328c8a00-2991-11eb-827e-305a89be043b.png) and when the user would be loggedin then we can show his own avatar? What say @Irev-Dev
Irev-Dev (Migrated from github.com) reviewed 2020-11-18 07:22:13 +01:00
web/src/layouts/MainLayout/MainLayout.js
Irev-Dev (Migrated from github.com) commented 2020-11-18 07:22:13 +01:00
Copy Link

I think I'd rather it be an explicit call to action, to sign up, best to have it as clear as possible.

I think I'd rather it be an explicit call to action, to sign up, best to have it as clear as possible.
Sign in to join this conversation.
Reviewers
No Reviewers
Yash-R
Irev-Dev
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#108
Delete Branch "kurt/issue-107"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?