From c19658b7f89eca6827f1911c8bca5031c7fc3fe1 Mon Sep 17 00:00:00 2001
From: Kurt Hutten <k.hutten@protonmail.ch>
Date: Fri, 24 Sep 2021 05:26:51 +1000
Subject: [PATCH] Enforce name and username with length

---
 app/api/src/services/users/users.ts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/app/api/src/services/users/users.ts b/app/api/src/services/users/users.ts
index e7fb075..d9e0ba4 100644
--- a/app/api/src/services/users/users.ts
+++ b/app/api/src/services/users/users.ts
@@ -22,7 +22,7 @@ function userNameVerification(userName: string): string {
 }
 
 function nameVerification(name: string) {
-  if (name && name.length < 3) {
+  if (typeof name === 'string' && name.length < 3) {
     throw new ForbiddenError('name too short')
   }
 }
@@ -53,7 +53,7 @@ export const createUserInsecure = ({
 }: {
   input: Prisma.UserUncheckedCreateInput
 }) => {
-  if (input.userName) {
+  if (typeof input.userName === 'string') {
     input.userName = userNameVerification(input.userName)
   }
   nameVerification(input.name)
@@ -70,7 +70,7 @@ export const updateUser = ({
   input: Prisma.UserUncheckedCreateInput
 }) => {
   requireAuth()
-  if (input.userName) {
+  if (typeof input.userName === 'string') {
     input.userName = userNameVerification(input.userName)
   }
   nameVerification(input.name)
@@ -89,7 +89,7 @@ export const updateUserByUserName = async ({
 }) => {
   requireAuth()
   await requireOwnership({ userName })
-  if (input.userName) {
+  if (typeof input.userName === 'string') {
     input.userName = userNameVerification(input.userName)
   }
   nameVerification(input.name)