h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

Make sure the code-init is robust when local storage is empty

Browse Source 
Plus fix local storage for old code
This commit is contained in:
Kurt Hutten
2021-05-30 13:43:56 +10:00
parent d7aaeda187
commit bd7aa4cc4e
4 changed files with 14 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/web/src/components/IdeEditor/IdeEditor.js
View File

@@ -1,6 +1,6 @@
import { useContext, Suspense, lazy } from 'react'
import { IdeContext } from 'src/components/IdeToolbarNew'
import { codeStorageKey } from 'src/helpers/hooks/useIdeState'
import { makeCodeStoreKey } from 'src/helpers/hooks/useIdeState'
import { requestRender } from 'src/helpers/hooks/useIdeState'
const Editor = lazy(() => import('@monaco-editor/react'))
@@ -38,7 +38,7 @@ const IdeEditor = () => {
camera: state.camera,
})
})
localStorage.setItem(codeStorageKey, state.code)
localStorage.setItem(makeCodeStoreKey(state.ideType), state.code)
}
}
const loading = (

8
app/web/src/components/IdeToolbarNew/IdeToolbarNew.js
View File

@@ -1,7 +1,7 @@
import { createContext, useEffect } from 'react'
import IdeContainer from 'src/components/IdeContainer'
import { isBrowser } from '@redwoodjs/prerender/browserUtils'
import { useIdeState, codeStorageKey } from 'src/helpers/hooks/useIdeState'
import { useIdeState, makeCodeStoreKey } from 'src/helpers/hooks/useIdeState'
import { copyTextToClipboard } from 'src/helpers/clipboard'
import { requestRender } from 'src/helpers/hooks/useIdeState'
import { encode, decode } from 'src/helpers/compress'
@@ -74,7 +74,7 @@ const IdeToolbarNew = ({ cadPackage }) => {
camera: state.camera,
})
})
localStorage.setItem(codeStorageKey, state.code)
localStorage.setItem(makeCodeStoreKey(state.ideType), state.code)
}
function handleMakeLink() {
if (isBrowser) {
@@ -83,8 +83,8 @@ const IdeToolbarNew = ({ cadPackage }) => {
copyTextToClipboard(window.location.href)
}
}
const PullTitleFromFirstLine = (code) => {
const firstLine = code.split('\n').filter(identity)[0]
const PullTitleFromFirstLine = (code = '') => {
const firstLine = code.split('\n').filter(identity)[0] || ''
if (!(firstLine.startsWith('//') || firstLine.startsWith('#'))) {
return 'object.stl'
}