h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

Fix JSCAD, useEdgeSplit issue

Browse Source
This commit is contained in:
Kurt Hutten
2021-08-18 05:16:16 +10:00
parent 8dbb0468f8
commit 9186e457d9
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/web/src/components/IdeViewer/IdeViewer.tsx
View File

@@ -10,7 +10,7 @@ import {
Environment, Environment,
useTexture, useTexture,
} from '@react-three/drei' } from '@react-three/drei'
import { useEdgeSplit } from 'src/helpers/hooks/useEdegeSplit' import { useEdgeSplit } from 'src/helpers/hooks/useEdgeSplit'
import { Vector3 } from 'three' import { Vector3 } from 'three'
import { requestRender } from 'src/helpers/hooks/useIdeState' import { requestRender } from 'src/helpers/hooks/useIdeState'
import texture from './dullFrontLitMetal.png' import texture from './dullFrontLitMetal.png'

4
app/web/src/helpers/hooks/useEdegeSplit.ts → app/web/src/helpers/hooks/useEdgeSplit.ts
View File

@@ -16,13 +16,13 @@ export function useEdgeSplit(
React.useEffect(() => { React.useEffect(() => {
if (!original.current && ref.current) { if (!original.current && ref.current) {
original.current = ref.current.geometry.clone() original.current = ref.current.geometry?.clone()
modifier.current = new EdgeSplitModifier() modifier.current = new EdgeSplitModifier()
} }
}, []) }, [])
React.useEffect(() => { React.useEffect(() => {
original.current = dependantGeometry.clone() original.current = dependantGeometry?.clone?.()
modifier.current = new EdgeSplitModifier() modifier.current = new EdgeSplitModifier()
}, [dependantGeometry]) }, [dependantGeometry])