h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

fix plus button z-index (#530)

Browse Source 
The preserve-3d fix for the FF parallax broke the plus button as the
popover was always beneath the main body.

normal z-index fixes didn't apply since it was 3d z-index problem.
This commit was merged in pull request #530.
This commit is contained in:
Kurt Hutten
2021-09-25 17:25:08 +10:00
committed by GitHub
parent 06dbc35cf8
commit 0ba4ec4e21
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/web/src/layouts/MainLayout/MainLayout.css
View File

@@ -1,3 +1,7 @@
.preserve-3d-for-children * { .preserve-3d-for-children * {
transform-style: preserve-3d; transform-style: preserve-3d;
} }
.preserve-3d-for-children {
transform-style: preserve-3d;
}

4
app/web/src/layouts/MainLayout/MainLayout.js
View File

@@ -71,7 +71,7 @@ const MainLayout = ({ children, shouldRemoveFooterInIde }) => {
}, [hash, client]) }, [hash, client])
return ( return (
<div <div
className="h-full flex flex-col ch-scrollbar overflow-y-scroll preserve-3d-for-children overflow-x-hidden" className="h-full flex flex-col ch-scrollbar overflow-y-scroll overflow-x-hidden"
style={{ perspective: '1px', perspectiveOrigin: 'top center' }} style={{ perspective: '1px', perspectiveOrigin: 'top center' }}
> >
<header id="cadhub-main-header"> <header id="cadhub-main-header">
@@ -171,7 +171,7 @@ const MainLayout = ({ children, shouldRemoveFooterInIde }) => {
open={isLoginModalOpen} open={isLoginModalOpen}
onClose={() => setIsLoginModalOpen(false)} onClose={() => setIsLoginModalOpen(false)}
/> />
<main className="flex-grow bg-ch-gray-800">{children}</main> <main className="flex-grow bg-ch-gray-800 preserve-3d-for-children">{children}</main>
{!shouldRemoveFooterInIde && <Footer />} {!shouldRemoveFooterInIde && <Footer />}
</div> </div>
) )