From 706864a4da14140b624305de18cbed19f751e6c6 Mon Sep 17 00:00:00 2001 From: Edward Firmo <94725493+edwardtfn@users.noreply.github.com> Date: Wed, 10 Apr 2024 12:42:58 +0200 Subject: [PATCH 1/6] Allow to 200 char per line --- .flake8 | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 .flake8 diff --git a/.flake8 b/.flake8 new file mode 100644 index 0000000..f60db99 --- /dev/null +++ b/.flake8 @@ -0,0 +1,3 @@ +[flake8] +max-line-length = 200 +ignore = E402 # To do: remove this before v4.4 From 94ad0211e00d5b1938a70a43d488b4d53841f4fd Mon Sep 17 00:00:00 2001 From: Edward Firmo <94725493+edwardtfn@users.noreply.github.com> Date: Wed, 10 Apr 2024 12:51:52 +0200 Subject: [PATCH 2/6] Update .flake8 --- .flake8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.flake8 b/.flake8 index f60db99..b807b89 100644 --- a/.flake8 +++ b/.flake8 @@ -1,3 +1,3 @@ [flake8] max-line-length = 200 -ignore = E402 # To do: remove this before v4.4 +ignore = F401 # To do: remove this before v4.4 From b5784187ae27762e54cca4c824f94f1b138bc86d Mon Sep 17 00:00:00 2001 From: Edward Firmo <94725493+edwardtfn@users.noreply.github.com> Date: Wed, 10 Apr 2024 12:56:18 +0200 Subject: [PATCH 3/6] Replace python validation --- .flake8 | 3 --- .github/workflows/validate_python.yml | 25 +++++++++++-------------- 2 files changed, 11 insertions(+), 17 deletions(-) delete mode 100644 .flake8 diff --git a/.flake8 b/.flake8 deleted file mode 100644 index b807b89..0000000 --- a/.flake8 +++ /dev/null @@ -1,3 +0,0 @@ -[flake8] -max-line-length = 200 -ignore = F401 # To do: remove this before v4.4 diff --git a/.github/workflows/validate_python.yml b/.github/workflows/validate_python.yml index 896a2a8..331fc03 100644 --- a/.github/workflows/validate_python.yml +++ b/.github/workflows/validate_python.yml @@ -12,22 +12,19 @@ on: workflow_dispatch: jobs: - flake8_py3: + flake8-lint: runs-on: ubuntu-latest + name: Lint steps: - - name: Setup Python - uses: actions/setup-python@v1 + - name: Check out source repository + uses: actions/checkout@v3 + - name: Set up Python environment + uses: actions/setup-python@v4 with: - python-version: 3.7.17 - architecture: x64 - - name: Checkout PyTorch - uses: actions/checkout@main - - name: Install flake8 - run: pip install flake8 - - name: Run flake8 - uses: suo/flake8-github-action@releases/v1 + python-version: "3.11" + - name: flake8 Lint + uses: py-actions/flake8@v2 with: - checkName: 'flake8_py3' # NOTE: this needs to be the same as the job name - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + ignore: "F401" + max-line-length: "200" ... From 77f9cf66f144e40903c64031e3823a5b0d2ec461 Mon Sep 17 00:00:00 2001 From: Edward Firmo <94725493+edwardtfn@users.noreply.github.com> Date: Wed, 10 Apr 2024 12:58:51 +0200 Subject: [PATCH 4/6] Update validate_python.yml --- .github/workflows/validate_python.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/validate_python.yml b/.github/workflows/validate_python.yml index 331fc03..a075a91 100644 --- a/.github/workflows/validate_python.yml +++ b/.github/workflows/validate_python.yml @@ -25,6 +25,7 @@ jobs: - name: flake8 Lint uses: py-actions/flake8@v2 with: - ignore: "F401" - max-line-length: "200" + #ignore: "F401" + #max-line-length: "200" + path: "components/nspanel_ha_blueprint" ... From 1cdd4173409a97451b2c1b343c0b33bb8e6a5f48 Mon Sep 17 00:00:00 2001 From: Edward Firmo <94725493+edwardtfn@users.noreply.github.com> Date: Wed, 10 Apr 2024 13:00:18 +0200 Subject: [PATCH 5/6] Update validate_python.yml --- .github/workflows/validate_python.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/validate_python.yml b/.github/workflows/validate_python.yml index a075a91..9391c0b 100644 --- a/.github/workflows/validate_python.yml +++ b/.github/workflows/validate_python.yml @@ -25,7 +25,7 @@ jobs: - name: flake8 Lint uses: py-actions/flake8@v2 with: - #ignore: "F401" - #max-line-length: "200" + ignore: "F401" # To do: remove for v4.4 + max-line-length: "200" path: "components/nspanel_ha_blueprint" ... From 9cb230fd5f21ab6f8d7a45120ce4e30eaafdd0a8 Mon Sep 17 00:00:00 2001 From: Edward Firmo <94725493+edwardtfn@users.noreply.github.com> Date: Wed, 10 Apr 2024 13:02:25 +0200 Subject: [PATCH 6/6] Update validate_python.yml --- .github/workflows/validate_python.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/validate_python.yml b/.github/workflows/validate_python.yml index 9391c0b..85489ce 100644 --- a/.github/workflows/validate_python.yml +++ b/.github/workflows/validate_python.yml @@ -17,9 +17,9 @@ jobs: name: Lint steps: - name: Check out source repository - uses: actions/checkout@v3 + uses: actions/checkout@main - name: Set up Python environment - uses: actions/setup-python@v4 + uses: actions/setup-python@main with: python-version: "3.11" - name: flake8 Lint