From 9a761dbc71f949aa9eb15f5eb1e2243473bde840 Mon Sep 17 00:00:00 2001 From: Edward Firmo <94725493+edwardtfn@users.noreply.github.com> Date: Wed, 17 Jan 2024 02:04:42 +0100 Subject: [PATCH] Replace deprecated global `display_last_brightness` on "Set display as a light" --- .test/esphome_advanced_climate_heat_customizations.yaml | 2 +- ReleaseNotes.md | 5 +++++ docs/customization.md | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.test/esphome_advanced_climate_heat_customizations.yaml b/.test/esphome_advanced_climate_heat_customizations.yaml index 201f11f..1a5db65 100644 --- a/.test/esphome_advanced_climate_heat_customizations.yaml +++ b/.test/esphome_advanced_climate_heat_customizations.yaml @@ -158,7 +158,7 @@ script: if (brightness != current_brightness) { if (current_page->state != "screensaver" and brightness > 0) { auto call = display_light->turn_on(); - call.set_brightness(static_cast(id(display_last_brightness)) / 100.0f); + call.set_brightness(static_cast(current_brightness->state) / 100.0f); call.perform(); } else if (display_light->current_values.is_on()) { auto call = display_light->turn_off(); diff --git a/ReleaseNotes.md b/ReleaseNotes.md index 74a46cd..bf503a1 100644 --- a/ReleaseNotes.md +++ b/ReleaseNotes.md @@ -366,6 +366,11 @@ Your feedback and support are crucial to our continuous improvement. ## Patch v4.2.3 Bug fixes and minor enhancements. +> [!IMPORTANT] +> **Breaking Change**: If you are using the [Customization "Set display as a light"](https://github.com/Blackymas/NSPanel_HA_Blueprint/blob/main/docs/customization.md#set-display-as-a-light) +> please change the line `call.set_brightness(static_cast(id(display_last_brightness)) / 100.0f);` to `call.set_brightness(static_cast(current_brightness->state) / 100.0f);` +> as that global variable was replaced by a new sensor. + We encourage all users to update their components to this latest version for the best experience. While this update is compatible with existing v4.2 components, it offers optimized performance and usability when fully updated. diff --git a/docs/customization.md b/docs/customization.md index a78ca50..49e3c2d 100644 --- a/docs/customization.md +++ b/docs/customization.md @@ -393,7 +393,7 @@ script: if (brightness != current_brightness) { if (current_page->state != "screensaver" and brightness > 0) { auto call = display_light->turn_on(); - call.set_brightness(static_cast(id(display_last_brightness)) / 100.0f); + call.set_brightness(static_cast(current_brightness->state) / 100.0f); call.perform(); } else if (display_light->current_values.is_on()) { auto call = display_light->turn_off();