diff --git a/.github/workflows/validate_esphome.yml b/.github/workflows/validate_esphome.yml index 0baae6b..5f11d17 100644 --- a/.github/workflows/validate_esphome.yml +++ b/.github/workflows/validate_esphome.yml @@ -191,48 +191,48 @@ jobs: with: yaml_file: "./.test/esphome_advanced_climate_heat_customizations.yaml" - build_prebuilt_firmware: - name: Prebuilt Firmware - runs-on: ubuntu-latest - needs: build_core # Ensure this job runs after the core build job - if: github.ref == 'refs/heads/dev' || github.base_ref == 'dev' - steps: - - uses: actions/checkout@main - with: - fetch-depth: '0' + # build_prebuilt_firmware: + # name: Prebuilt Firmware + # runs-on: ubuntu-latest + # needs: build_core # Ensure this job runs after the core build job + # if: github.ref == 'refs/heads/dev' || github.base_ref == 'dev' + # steps: + # - uses: actions/checkout@main + # with: + # fetch-depth: '0' - - name: Build ESPHome Prebuilt Firmware - uses: barndawgie/build-action@v1.9.0 - with: - yaml_file: prebuilt/nspanel_esphome_prebuilt.yaml + # - name: Build ESPHome Prebuilt Firmware + # uses: barndawgie/build-action@v1.9.0 + # with: + # yaml_file: prebuilt/nspanel_esphome_prebuilt.yaml - - name: Move and Rename Firmware File - run: | - mkdir -p prebuilt - cp prebuilt/.esphome/build/nspanel/.pioenvs/nspanel/firmware.bin prebuilt/nspanel_esphome_prebuilt.bin || true - cp prebuilt/.esphome/build/nspanel/.pioenvs/nspanel/firmware-factory.bin prebuilt/nspanel_esphome_prebuilt-factory.bin || true + # - name: Move and Rename Firmware File + # run: | + # mkdir -p prebuilt + # cp prebuilt/.esphome/build/nspanel/.pioenvs/nspanel/firmware.bin prebuilt/nspanel_esphome_prebuilt.bin || true + # cp prebuilt/.esphome/build/nspanel/.pioenvs/nspanel/firmware-factory.bin prebuilt/nspanel_esphome_prebuilt-factory.bin || true - - name: Set Commit Message - id: set_commit_message - run: | - if [[ "${{ github.event_name }}" == "pull_request" ]]; then - echo "COMMIT_MESSAGE=Pre-built firmware for NSPanel - ${{ github.event.pull_request.title }}" >> $GITHUB_ENV - elif [[ "${{ github.event_name }}" == "push" ]]; then - commit_message=$(git log -1 --pretty=format:'%s') - echo "COMMIT_MESSAGE=Pre-built firmware for NSPanel - $commit_message" >> $GITHUB_ENV - else - echo "COMMIT_MESSAGE=Pre-built firmware for NSPanel" >> $GITHUB_ENV - fi + # - name: Set Commit Message + # id: set_commit_message + # run: | + # if [[ "${{ github.event_name }}" == "pull_request" ]]; then + # echo "COMMIT_MESSAGE=Pre-built firmware for NSPanel - ${{ github.event.pull_request.title }}" >> $GITHUB_ENV + # elif [[ "${{ github.event_name }}" == "push" ]]; then + # commit_message=$(git log -1 --pretty=format:'%s') + # echo "COMMIT_MESSAGE=Pre-built firmware for NSPanel - $commit_message" >> $GITHUB_ENV + # else + # echo "COMMIT_MESSAGE=Pre-built firmware for NSPanel" >> $GITHUB_ENV + # fi - - name: Commit and Push Firmware Files - run: | - git config --global user.name 'GitHub Actions' - git config --global user.email 'actions@github.com' - git add prebuilt/*.bin - git commit -m "${{ env.COMMIT_MESSAGE }}" - git push - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + # - name: Commit and Push Firmware Files + # run: | + # git config --global user.name 'GitHub Actions' + # git config --global user.email 'actions@github.com' + # git add prebuilt/*.bin + # git commit -m "${{ env.COMMIT_MESSAGE }}" + # git push + # env: + # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} build_climate_cool_bluetooth_proxy: name: Climate cool & BLE proxy diff --git a/ReleaseNotes.md b/ReleaseNotes.md index eb5eccf..232a91c 100644 --- a/ReleaseNotes.md +++ b/ReleaseNotes.md @@ -252,7 +252,8 @@ This fix ensures temperature readings are accurately represented according to th ### Resolution for Panel Naming When `device_name` Is Not Provided (#1907) - **Criticality:** Medium - **Affected Components:** ESPHome -- **Description:** Corrected a bug that caused the new "Device Name" sensor to report "nspanel" and therefore fail on defining services names when a `device_name` substitution was not specified by the user. +- **Description:** Corrected a bug that caused the new "Device Name" sensor to report "nspanel" +and therefore fail on defining services names when a `device_name` substitution was not specified by the user. ### External Temperature Sensor Selection Now Correctly Overrides Embedded Sensor Value (#1911) - **Criticality:** Medium